Add support of NimBLE host to Blufi (IDFGH-5122) #6904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PSONALl
commented
Apr 20, 2021
PSONALl
commented
- Added Blufi service and its characteristics to GATT database for NimBLE
- Handled Read, Write and Notify operations on characteristics of Blufi service with NimBLE
- In the Blufi example, separated the BLE host-specific part in a separate file
- Moved the Blufi related code to common
|
|
github-actions
bot
changed the title
|
Excellent! Thanks for adding the support @PSONALl |
|
This is an exciting feature. |
components/bt/common/btc/profile/esp/blufi/bluedroid_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
PSONALl
force-pushed
the
nimble/ble_app
branch
6 times, most recently
from
b3f9355
to
9b5e772
Compare
components/bt/common/btc/profile/esp/blufi/nimble_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
components/bt/common/btc/profile/esp/blufi/nimble_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
components/bt/common/btc/profile/esp/blufi/nimble_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
components/bt/common/btc/profile/esp/blufi/nimble_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
components/bt/common/btc/profile/esp/blufi/nimble_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
components/bt/common/btc/profile/esp/blufi/nimble_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
components/bt/common/btc/profile/esp/blufi/nimble_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
|
Hi @PSONALl , excellent work there to add NimBLE port to BluFi !! I have left a few minor comments :) |
Thanks! @prasad-alatkar |
PSONALl
force-pushed
the
nimble/ble_app
branch
2 times, most recently
from
882fdd3
to
4468917
Compare
|
@prasad-alatkar I have added the changes you suggested. |
components/bt/common/btc/profile/esp/blufi/bluedroid_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
components/bt/common/btc/profile/esp/blufi/bluedroid_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
components/bt/common/btc/profile/esp/blufi/bluedroid_host/esp_blufi.c
Outdated
Show resolved
Hide resolved
PSONALl
force-pushed
the
nimble/ble_app
branch
3 times, most recently
from
dee0e6e
to
c4a2fb6
Compare
PSONALl
force-pushed
the
nimble/ble_app
branch
2 times, most recently
from
582917b
to
c739d95
Compare
rahult-github
approved these changes
Jun 24, 2021
espressif-bot
pushed a commit
that referenced
this pull request
Jul 16, 2021
espressif-bot
pushed a commit
that referenced
this pull request
Jul 18, 2021
|
Thanks for your contribution again, changes merged with 00b9df2. |
espressif-bot
added
Status: In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.