Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Use images instead of emojis in the support table of the README #7497

Closed
wants to merge 2 commits into from
Closed

Docs: Use images instead of emojis in the support table of the README #7497

wants to merge 2 commits into from

Conversation

dobairoland
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@igrr
Copy link
Member

igrr commented Aug 31, 2021 •
edited

The images look a bit cropped and low-res (Chrome, macOS):

Screenshot 2021-08-31 at 12 24 11

@dobairoland
Copy link
Collaborator Author

@radimkarnis I don't see an exception as before but the internal task hasn't been created. Could you please check it?

@radimkarnis
Copy link
Collaborator

@dobairoland thank you for checking this. PRs from collaborators are not synced by default. See espressif/github-actions@fa06c1b

@dobairoland
Copy link
Collaborator Author

Thanks @radimkarnis. I missed that point.

@dobairoland dobairoland self-assigned this Sep 2, 2021
@dobairoland dobairoland deleted the bugfix/readme_images branch September 14, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrr igrr igrr approved these changes

Assignees

@dobairoland dobairoland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dobairoland @CLAassistant @igrr @radimkarnis