Define $IsWindows if not defined. (IDFGH-6181) #7858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `$IsWindows` PowerShell variable was added in PowerShell Core 6 and PowerShell 7, and is not present in earlier PowerShell versions. Set to true if undefined. This fixes espressif#7820. The first version to run on non-Windows platforms was PowerShell Core 6.0[^1] which means that IsWindows is guaranteed to be defined on all non-Windows systems. So, if undefined this indicates a Windows platform. [^1]: https://docs.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.2#release-history
github-actions
bot
changed the title
|
Thanks for your contribution. |
|
I verified this on PowerShell 5.1. |
|
Great fix @cmumford. Thanks! I move both of your PRs into our test queue. They will be closed when they get merged. |
espressif-bot
added
Status: In Progress
espressif-bot
pushed a commit
that referenced
this pull request
Nov 20, 2021
The `$IsWindows` PowerShell variable was added in PowerShell Core 6 and PowerShell 7, and is not present in earlier PowerShell versions. Set to true if undefined. This fixes #7820. The first version to run on non-Windows platforms was PowerShell Core 6.0[^1] which means that IsWindows is guaranteed to be defined on all non-Windows systems. So, if undefined this indicates a Windows platform. [^1]: https://docs.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.2#release-history Closes #7858 Closes #7820
espressif-bot
pushed a commit
that referenced
this pull request
Nov 24, 2021
The `$IsWindows` PowerShell variable was added in PowerShell Core 6 and PowerShell 7, and is not present in earlier PowerShell versions. Set to true if undefined. This fixes #7820. The first version to run on non-Windows platforms was PowerShell Core 6.0[^1] which means that IsWindows is guaranteed to be defined on all non-Windows systems. So, if undefined this indicates a Windows platform. [^1]: https://docs.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.2#release-history Closes #7858 Closes #7820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$IsWindowsPowerShell variable was added in PowerShell Core 6 andPowerShell 7, and is not present in earlier PowerShell versions. Set to
true if undefined. This fixes #7820.
The first version to run on non-Windows platforms was PowerShell Core
6.01 which means that IsWindows is guaranteed to be defined on all
non-Windows systems. So, if undefined this indicates a Windows platform.
Footnotes
https://docs.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.2#release-history ↩