Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: Print buffer when reading an escape character (IDFGH-6443) #8100

Merged
merged 1 commit into from Jan 4, 2022

Conversation

bugadani
Copy link
Contributor

The color converter script currently discards partially processed data when it encounters an escape character. This can result in missing characters when the user prints escape sequences that are not expected by the script. This PR fixes this issue.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 17, 2021
@github-actions github-actions bot changed the title monitor: Print buffer when reading an escape character monitor: Print buffer when reading an escape character (IDFGH-6443) Dec 17, 2021
@dobairoland
Copy link
Collaborator

Thanks for the contribution. We will get back to you soon if there is any question regarding this.

@sio13
Copy link
Contributor

sio13 commented Dec 29, 2021

sha=04589b565f11dd3bcd0df967ea9ed5370aa318c9

@dobairoland dobairoland self-requested a review December 29, 2021 13:20
@dobairoland dobairoland added the PR-Sync-Merge Pull request sync as merge commit label Dec 29, 2021
@dobairoland
Copy link
Collaborator

sha=04589b565f11dd3bcd0df967ea9ed5370aa318c9

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Resolution: NA Issue resolution is unavailable labels Jan 3, 2022
@espressif-bot espressif-bot merged commit 04589b5 into espressif:master Jan 4, 2022
@bugadani bugadani deleted the patch-4 branch January 4, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants