Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set success when closing socket (IDFGH-6709) #8337

Closed
wants to merge 1 commit into from
Closed

Set success when closing socket (IDFGH-6709) #8337

wants to merge 1 commit into from

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Feb 2, 2022

No description provided.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 2, 2022
@github-actions github-actions bot changed the title Set success when closing socket Set success when closing socket (IDFGH-6709) Feb 2, 2022
@mahavirj
Copy link
Member

mahavirj commented Feb 3, 2022

@bugadani Could you please elaborate on issue your were facing? Just asking to see if we can add simple test for this.

@bugadani
Copy link
Contributor Author

bugadani commented Feb 3, 2022

@mahavirj I have updated my project from esp-idf 4.3 to 4.4. I am making unsecure http requests and the esp_http_client_close function was returning ESP_FAIL (-1) even for requests that seemed successful. Might be that I forgot to update my config, but I tracked the source of that ESP_FAIL value to the code branch in this PR.

@mahavirj
Copy link
Member

mahavirj commented Feb 3, 2022

sha=3aa41c438bccd92c1e381db335658193f5fdb7a1

@mahavirj mahavirj added the PR-Sync-Merge Pull request sync as merge commit label Feb 3, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Feb 7, 2022
@bugadani bugadani deleted the patch-4 branch February 9, 2022 12:48
espressif-bot pushed a commit that referenced this pull request Feb 17, 2022
@bugadani @mahavirj
Set success when closing socket
9e892fb 
Closes #8337
Closes IDFGH-6709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahavirj mahavirj mahavirj approved these changes

Assignees
No one assigned
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bugadani @mahavirj @espressif-bot