export.fish: set IDF_PATH without changing current working directory (IDFGH-8140) #9637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
|
Thank you for the contribution. We'll take a look at this soon. |
|
I just found that my initial commit didn't take care of the case when the source command is executed under the root directory of esp-idf. The last commit I uploaded should fix it. |
mfialaf
reviewed
Aug 30, 2022
imcaizheng
force-pushed
the
export-fish-script-fix
branch
from
bf78025
to
84ec01c
Compare
|
sha=84ec01c3301c33ec9a61ff03ab0703c653d39180 |
espressif-bot
added
Status: In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.