Added constructors for cluster config structures with const members (CON-389) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
shubhamdp
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
@Diegorro98 PR looks good to me, left few minor comments.
Also, Can you please add the Fixes https://github.com/espressif/esp-matter/issues/280 to one of your commit please. This will automatically close this PR and the issue once this gets merged internally.
Diegorro98
force-pushed
the
bugfix/const_constructors
branch
from
1faf244
to
fc27578
Compare
Diegorro98
force-pushed
the
bugfix/const_constructors
branch
from
fc27578
to
0e86cc1
Compare
|
@shubhamdp Thank you for your answer 😊. Requested changes done! |
|
@Diegorro98 Thanks a lot for the PR. I have trigged the build pipeline on this PR, once that is green, this will be merged. |
|
@Diegorro98 Thanks for your contribution. The PR has now been merged to Github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved the problem where
end_product_typecouldn't be customized at the start of the application (Fixes #280)Because
end_product_typenow is const in order to follow Matter specification and the value can not be changed after the cluster instance has been initialized, now there are two constructors that allows to create a window covering endpoint configuration with a cluster configuration that has a customend_product_type, so you can create it just like this:window_covering_device::config_t config(static_cast<uint8_t>(chip::app::Clusters::WindowCovering::EndProductType::kTiltOnlyInteriorBlind));This also has been done for
pumpandpump_configuration_and_control.Also updated documentation to explain these special cases as suggested @shubhamdp.