support r/w floating(single) value type (CON-1077) #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
Sure. No worries. Thanks @YOGYUI |
dhrishi
reviewed
Mar 12, 2024
- concentration measurement clusters: change attr value type (float) - remove 'add uncentainty attribute' - add 'measurement medium' attribute
YOGYUI
force-pushed
the
feature/support-float-attr-val
branch
from
add04e2
to
810a9ca
Compare
jadhavrohit924
approved these changes
Mar 21, 2024
|
Can you merge this PR is it's OK? |
|
@dhrishi Any progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhrishi I recently lost my remote and local branch while squashing PR commits because of my mistake, so reopened PR with new branch.
I deeply sorry for inconvenience.
[Related issue]
singledata type attribute value handling. (CON-1051) #843[Major changes]
ConcentrationMeasurementclusters follow Matter specifications (2.10.6)MeasuredValue,MinMeasuredValue,MaxMeasuredValue,PeakMeasuredValue,AverageMeasuredValue,Uncertainty)Uncertaintyattribute phrase (optional attribute)MeasurementMediumattribute phrase (mandatory attribute)AverageMeasurementfeature config struct[Minor changes]