Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in total_volatile_organic_compounds_concentration_measuremen… (CON-1140) #918

Closed
wants to merge 2 commits into from

Conversation

kibergus
Copy link

@kibergus kibergus commented May 6, 2024

The header and other locations use plural compounds in the namespace name. But .cpp has the functions defined in a namespace with a singular compound. As a result attempting to define tvoc sensor leads to undefined symbols during linking.

#911

@CLAassistant
Copy link

CLAassistant commented May 6, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Fix typo in total_volatile_organic_compounds_concentration_measuremen… Fix typo in total_volatile_organic_compounds_concentration_measuremen… (CON-1140) May 6, 2024
@jadhavrohit924
Copy link
Contributor

Thanks for the PR @kibergus

@dhrishi
Copy link
Collaborator

dhrishi commented May 15, 2024

Hi @kibergus The changes are merged with c9cae5a. The commits were squashed during merge and that's why the PR didn't get auto-closed. Sorry for the confusion.

@dhrishi dhrishi closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants