Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL's query-string portion is getting cut off. (IDFGH-3565) #161

Closed
klisevich opened this issue Jun 28, 2020 · 1 comment
Closed

URL's query-string portion is getting cut off. (IDFGH-3565) #161

klisevich opened this issue Jun 28, 2020 · 1 comment

Comments

@klisevich
Copy link

Hi!
I'm using MQTT over WebSocket in order to connect to amazon's endpoint with SigV4 pre-signed URL. There is an issue with ignoring query-string in mqtt_client.c:764
client->config->path = create_string(uri + puri.field_data[UF_PATH].off, puri.field_data[UF_PATH].len);
I'm getting path like wss://<endpoint>.iot.<region>.amazonaws.com/mqtt instead of wss://<endpoint>.iot.<region>.amazonaws.com/mqtt?Action=ListUsers&Version=2010-05-08.
What would you advise?

@github-actions github-actions bot changed the title URL's query-string portion is getting cut off. URL's query-string portion is getting cut off. (IDFGH-3565) Jun 28, 2020
@ESP-Marius
Copy link
Contributor

Hi @klisevich

Thanks for making us aware of this issue. I've created a MR to allow the query part of the uri to be added to the path. We'll update this issue when it's been merged.

espressif-bot pushed a commit to espressif/esp-idf that referenced this issue Sep 10, 2020
SSL: add config option for skipping common name check
esp-mqtt commit: espressif/esp-mqtt@5e8950e)
Closes espressif/esp-mqtt#158

SSL: add support for tls with secure element (ATECC608A)
esp-mqtt commit: espressif/esp-mqtt@a7ff9af)
Closes espressif/esp-mqtt#156

Websocket: Allow the query part of the uri to be a part of the path
esp-mqtt commit: espressif/esp-mqtt@40b06de)
Closes espressif/esp-mqtt#161

Config: Add check for consistency between config settings
esp-mqtt commit: espressif/esp-mqtt@8a412c1)

Add IDF version check for secure element feature
esp-mqtt commit: espressif/esp-mqtt@db4bce0)

Fix esp_mqtt_client_stop deadlock
esp-mqtt commit: espressif/esp-mqtt@5e17dca)
Closes espressif/esp-mqtt#163

Add dispatch error event for read errors
esp-mqtt commit: espressif/esp-mqtt@d4aaec0
Closes #5704

Cleanup expired messages when offline
esp-mqtt commit: espressif/esp-mqtt@bdadd77
Closes #5668

esp_mqtt_client_publish now returns msg id for QoS > 0 when offline
esp-mqtt commit: espressif/esp-mqtt@f7325bf
espressif-bot pushed a commit to espressif/esp-idf that referenced this issue Sep 16, 2020
SSL: add config option for skipping common name check
esp-mqtt commit: espressif/esp-mqtt@5e8950e)
Closes espressif/esp-mqtt#158

SSL: add support for tls with secure element (ATECC608A)
esp-mqtt commit: espressif/esp-mqtt@a7ff9af)
Closes espressif/esp-mqtt#156

Websocket: Allow the query part of the uri to be a part of the path
esp-mqtt commit: espressif/esp-mqtt@40b06de)
Closes espressif/esp-mqtt#161

Config: Add check for consistency between config settings
esp-mqtt commit: espressif/esp-mqtt@8a412c1)

Add IDF version check for secure element feature
esp-mqtt commit: espressif/esp-mqtt@db4bce0)

Fix esp_mqtt_client_stop deadlock
esp-mqtt commit: espressif/esp-mqtt@5e17dca)
Closes espressif/esp-mqtt#163

Add dispatch error event for read errors
esp-mqtt commit: espressif/esp-mqtt@d4aaec0
Closes #5704

Cleanup expired messages when offline
esp-mqtt commit: espressif/esp-mqtt@bdadd77
Closes #5668

esp_mqtt_client_publish now returns msg id for QoS > 0 when offline
esp-mqtt commit: espressif/esp-mqtt@f7325bf

Add support for Digital Signature through ESP-TLS
esp-mqtt commit: espressif/esp-mqtt@7d8e59d
espressif-bot pushed a commit to espressif/esp-idf that referenced this issue Sep 22, 2020
SSL: add config option for skipping common name check
esp-mqtt commit: espressif/esp-mqtt@5e8950e)
Closes espressif/esp-mqtt#158

SSL: add support for tls with secure element (ATECC608A)
esp-mqtt commit: espressif/esp-mqtt@a7ff9af)
Closes espressif/esp-mqtt#156

Websocket: Allow the query part of the uri to be a part of the path
esp-mqtt commit: espressif/esp-mqtt@40b06de)
Closes espressif/esp-mqtt#161

Config: Add check for consistency between config settings
esp-mqtt commit: espressif/esp-mqtt@8a412c1)

Add IDF version check for secure element feature
esp-mqtt commit: espressif/esp-mqtt@db4bce0)

Fix esp_mqtt_client_stop deadlock
esp-mqtt commit: espressif/esp-mqtt@5e17dca)
Closes espressif/esp-mqtt#163

Add dispatch error event for read errors
esp-mqtt commit: espressif/esp-mqtt@d4aaec0
Closes #5704

Cleanup expired messages when offline
esp-mqtt commit: espressif/esp-mqtt@bdadd77
Closes #5668

esp_mqtt_client_publish now returns msg id for QoS > 0 when offline
esp-mqtt commit: espressif/esp-mqtt@f7325bf
espressif-bot pushed a commit to espressif/esp-idf that referenced this issue Oct 30, 2020
SSL: add config option for skipping common name check
esp-mqtt commit: espressif/esp-mqtt@5e8950e)
Closes espressif/esp-mqtt#158

Websocket: Allow the query part of the uri to be a part of the path
esp-mqtt commit: espressif/esp-mqtt@40b06de)
Closes espressif/esp-mqtt#161

Config: Add check for consistency between config settings
esp-mqtt commit: espressif/esp-mqtt@8a412c1)

Add IDF version check for secure element feature
esp-mqtt commit: espressif/esp-mqtt@db4bce0)

Fix esp_mqtt_client_stop deadlock
esp-mqtt commit: espressif/esp-mqtt@5e17dca)
Closes espressif/esp-mqtt#163

Add dispatch error event for read errors
esp-mqtt commit: espressif/esp-mqtt@d4aaec0
Closes #5704

Cleanup expired messages when offline
esp-mqtt commit: espressif/esp-mqtt@bdadd77
Closes #5668

esp_mqtt_client_publish now returns msg id for QoS > 0 when offline
esp-mqtt commit: espressif/esp-mqtt@f7325bf
espressif-bot pushed a commit to espressif/esp-idf that referenced this issue Nov 10, 2020
SSL: add config option for skipping common name check
esp-mqtt commit: espressif/esp-mqtt@5e8950e)
Closes espressif/esp-mqtt#158

Websocket: Allow the query part of the uri to be a part of the path
esp-mqtt commit: espressif/esp-mqtt@40b06de)
Closes espressif/esp-mqtt#161

Config: Add check for consistency between config settings
esp-mqtt commit: espressif/esp-mqtt@8a412c1)

Add IDF version check for secure element feature
esp-mqtt commit: espressif/esp-mqtt@db4bce0)

Fix esp_mqtt_client_stop deadlock
esp-mqtt commit: espressif/esp-mqtt@5e17dca)
Closes espressif/esp-mqtt#163

Add dispatch error event for read errors
esp-mqtt commit: espressif/esp-mqtt@d4aaec0
Closes #5704

Cleanup expired messages when offline
esp-mqtt commit: espressif/esp-mqtt@bdadd77
Closes #5668

esp_mqtt_client_publish now returns msg id for QoS > 0 when offline
esp-mqtt commit: espressif/esp-mqtt@f7325bf
david-cermak pushed a commit that referenced this issue Dec 16, 2022
SSL: add config option for skipping common name check
esp-mqtt commit: 5e8950e)
Closes #158

SSL: add support for tls with secure element (ATECC608A)
esp-mqtt commit: a7ff9af)
Closes #156

Websocket: Allow the query part of the uri to be a part of the path
esp-mqtt commit: 40b06de)
Closes #161

Config: Add check for consistency between config settings
esp-mqtt commit: 8a412c1)

Add IDF version check for secure element feature
esp-mqtt commit: db4bce0)

Fix esp_mqtt_client_stop deadlock
esp-mqtt commit: 5e17dca)
Closes #163

Add dispatch error event for read errors
esp-mqtt commit: d4aaec0
Closes espressif/esp-idf#5704

Cleanup expired messages when offline
esp-mqtt commit: bdadd77
Closes espressif/esp-idf#5668

esp_mqtt_client_publish now returns msg id for QoS > 0 when offline
esp-mqtt commit: f7325bf

Add support for Digital Signature through ESP-TLS
esp-mqtt commit: 7d8e59d
egnor pushed a commit to egnor/esp-mqtt that referenced this issue Dec 23, 2022
SSL: add config option for skipping common name check
esp-mqtt commit: espressif@5e8950e)
Closes espressif#158

SSL: add support for tls with secure element (ATECC608A)
esp-mqtt commit: espressif@a7ff9af)
Closes espressif#156

Websocket: Allow the query part of the uri to be a part of the path
esp-mqtt commit: espressif@40b06de)
Closes espressif#161

Config: Add check for consistency between config settings
esp-mqtt commit: espressif@8a412c1)

Add IDF version check for secure element feature
esp-mqtt commit: espressif@db4bce0)

Fix esp_mqtt_client_stop deadlock
esp-mqtt commit: espressif@5e17dca)
Closes espressif#163

Add dispatch error event for read errors
esp-mqtt commit: espressif@d4aaec0
Closes espressif/esp-idf#5704

Cleanup expired messages when offline
esp-mqtt commit: espressif@bdadd77
Closes espressif/esp-idf#5668

esp_mqtt_client_publish now returns msg id for QoS > 0 when offline
esp-mqtt commit: espressif@f7325bf

Add support for Digital Signature through ESP-TLS
esp-mqtt commit: espressif@7d8e59d
egnor pushed a commit to egnor/esp-mqtt that referenced this issue Dec 23, 2022
SSL: add config option for skipping common name check
esp-mqtt commit: espressif@5e8950e)
Closes espressif#158

SSL: add support for tls with secure element (ATECC608A)
esp-mqtt commit: espressif@a7ff9af)
Closes espressif#156

Websocket: Allow the query part of the uri to be a part of the path
esp-mqtt commit: espressif@40b06de)
Closes espressif#161

Config: Add check for consistency between config settings
esp-mqtt commit: espressif@8a412c1)

Add IDF version check for secure element feature
esp-mqtt commit: espressif@db4bce0)

Fix esp_mqtt_client_stop deadlock
esp-mqtt commit: espressif@5e17dca)
Closes espressif#163

Add dispatch error event for read errors
esp-mqtt commit: espressif@d4aaec0
Closes espressif/esp-idf#5704

Cleanup expired messages when offline
esp-mqtt commit: espressif@bdadd77
Closes espressif/esp-idf#5668

esp_mqtt_client_publish now returns msg id for QoS > 0 when offline
esp-mqtt commit: espressif@f7325bf

Add support for Digital Signature through ESP-TLS
esp-mqtt commit: espressif@7d8e59d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants