Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP x509 Certificate Bundle for MQTTS (IDFGH-5277) #190

Closed
hasiflo opened this issue May 17, 2021 · 1 comment
Closed

ESP x509 Certificate Bundle for MQTTS (IDFGH-5277) #190

hasiflo opened this issue May 17, 2021 · 1 comment

Comments

@hasiflo
Copy link
Contributor

hasiflo commented May 17, 2021

Is your feature request related to a problem? Please describe.

Since ESP x509 Certificate Bundle is available for https requests, I also want to use them for mqtts to verify my connections without downloading or including a specific certificate.

Describe the solution you'd like

Include an additional esp_mqtt_client_config_t field to include the crt_bundle_attach callback
@github-actions github-actions bot changed the title ESP x509 Certificate Bundle for MQTTS ESP x509 Certificate Bundle for MQTTS (IDFGH-5277) May 17, 2021
@hasiflo hasiflo mentioned this issue May 17, 2021
Closed
@david-cermak
Copy link
Collaborator

Closed by your PR, in 06157be

espressif-bot pushed a commit to espressif/esp-idf that referenced this issue Jun 28, 2021
@david-cermak @espressif-bot
MQTT: Support for certificate bundle; Client clean-up
4f637e8 
* Closes #7040
* Merges #7041
* Update submodule: git log --oneline 9fdf7b61385633075d5c3b84803f2dd0578d7869..f10321a53b53a146ee299cfecc320b89c0cf6611

Detailed description of the changes:
* Remove unnecessary parentheses
  - esp-mqtt commit: espressif/esp-mqtt@db13533
  - esp-mqtt MR: espressif/esp-mqtt!101
* outbox: Cleanup all items when connection closes
  - esp-mqtt commit: espressif/esp-mqtt@1a94efe
  - esp-mqtt MR: espressif/esp-mqtt!104
* Outbox: Removes unnecessary calls to outbox_set_pending
  - esp-mqtt commit: espressif/esp-mqtt@36a3990
  - esp-mqtt MR: espressif/esp-mqtt!105
* MQTT: Makes abort connection function void.
  - esp-mqtt commit: espressif/esp-mqtt@67553ab
  - esp-mqtt MR: espressif/esp-mqtt!106
* Client: Removes unused defines
  - esp-mqtt commit: espressif/esp-mqtt@eec6f0e
  - esp-mqtt MR: espressif/esp-mqtt!100
  - Closes espressif/esp-mqtt#194
* Config: Added support for certificate bundle
  - esp-mqtt commit: espressif/esp-mqtt@06157be
  - esp-mqtt MR: espressif/esp-mqtt!98
  - Closes espressif/esp-mqtt#190
* Config: Adds missing field at config struct (path field)
  - esp-mqtt commit: espressif/esp-mqtt@5b27d18
  - esp-mqtt MR: espressif/esp-mqtt!96
* Client: Add support for partial transport writes
  - esp-mqtt commit: espressif/esp-mqtt@d8c9c7a
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Partially addresses #6940
* Client: Add support for Retain flag in messages posted by events
  - esp-mqtt commit: espressif/esp-mqtt@a00a313
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Closes espressif/esp-mqtt#193
* esp-mqtt: Added nullchecks for public APIs
  - esp-mqtt commit: espressif/esp-mqtt@2f57985
  - esp-mqtt MR: espressif/esp-mqtt!94
  - Closes espressif/esp-mqtt#185
* esp-mqtt: Reduce the includes used in all files
  - esp-mqtt commit: espressif/esp-mqtt@87fcce7
  - esp-mqtt MR: espressif/esp-mqtt!93
* mqtt_outbox: Use STAILQ_FOREACH for outbox_delete_single_expired
  - esp-mqtt commit: espressif/esp-mqtt@ff8e648
  - esp-mqtt MR: espressif/esp-mqtt!97
  - Merges espressif/esp-mqtt#187
* Client: Add optimize for depend on ssl
  - esp-mqtt commit: espressif/esp-mqtt@8f3cac8
  - esp-mqtt MR: espressif/esp-mqtt!95
projectgus pushed a commit to espressif/esp-idf that referenced this issue Jun 30, 2021
@david-cermak
MQTT: Support for certificate bundle; Client clean-up
9de4178 
* Closes #7040
* Merges #7041
* Update submodule: git log --oneline 9fdf7b61385633075d5c3b84803f2dd0578d7869..f10321a53b53a146ee299cfecc320b89c0cf6611

Detailed description of the changes:
* Remove unnecessary parentheses
  - esp-mqtt commit: espressif/esp-mqtt@db13533
  - esp-mqtt MR: espressif/esp-mqtt!101
* outbox: Cleanup all items when connection closes
  - esp-mqtt commit: espressif/esp-mqtt@1a94efe
  - esp-mqtt MR: espressif/esp-mqtt!104
* Outbox: Removes unnecessary calls to outbox_set_pending
  - esp-mqtt commit: espressif/esp-mqtt@36a3990
  - esp-mqtt MR: espressif/esp-mqtt!105
* MQTT: Makes abort connection function void.
  - esp-mqtt commit: espressif/esp-mqtt@67553ab
  - esp-mqtt MR: espressif/esp-mqtt!106
* Client: Removes unused defines
  - esp-mqtt commit: espressif/esp-mqtt@eec6f0e
  - esp-mqtt MR: espressif/esp-mqtt!100
  - Closes espressif/esp-mqtt#194
* Config: Added support for certificate bundle
  - esp-mqtt commit: espressif/esp-mqtt@06157be
  - esp-mqtt MR: espressif/esp-mqtt!98
  - Closes espressif/esp-mqtt#190
* Config: Adds missing field at config struct (path field)
  - esp-mqtt commit: espressif/esp-mqtt@5b27d18
  - esp-mqtt MR: espressif/esp-mqtt!96
* Client: Add support for partial transport writes
  - esp-mqtt commit: espressif/esp-mqtt@d8c9c7a
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Partially addresses #6940
* Client: Add support for Retain flag in messages posted by events
  - esp-mqtt commit: espressif/esp-mqtt@a00a313
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Closes espressif/esp-mqtt#193
* esp-mqtt: Added nullchecks for public APIs
  - esp-mqtt commit: espressif/esp-mqtt@2f57985
  - esp-mqtt MR: espressif/esp-mqtt!94
  - Closes espressif/esp-mqtt#185
* esp-mqtt: Reduce the includes used in all files
  - esp-mqtt commit: espressif/esp-mqtt@87fcce7
  - esp-mqtt MR: espressif/esp-mqtt!93
* mqtt_outbox: Use STAILQ_FOREACH for outbox_delete_single_expired
  - esp-mqtt commit: espressif/esp-mqtt@ff8e648
  - esp-mqtt MR: espressif/esp-mqtt!97
  - Merges espressif/esp-mqtt#187
* Client: Add optimize for depend on ssl
  - esp-mqtt commit: espressif/esp-mqtt@8f3cac8
  - esp-mqtt MR: espressif/esp-mqtt!95
david-cermak added a commit that referenced this issue Dec 16, 2022
@david-cermak @euripedesrocha
MQTT: Support for certificate bundle; Client clean-up
a8b0f47 
* Closes espressif/esp-idf#7040
* Merges espressif/esp-idf#7041
* Update submodule: git log --oneline 9fdf7b6..f10321a

Detailed description of the changes:
* Remove unnecessary parentheses
  - esp-mqtt commit: db13533
  - esp-mqtt MR: espressif/esp-mqtt!101
* outbox: Cleanup all items when connection closes
  - esp-mqtt commit: 1a94efe
  - esp-mqtt MR: espressif/esp-mqtt!104
* Outbox: Removes unnecessary calls to outbox_set_pending
  - esp-mqtt commit: 36a3990
  - esp-mqtt MR: espressif/esp-mqtt!105
* MQTT: Makes abort connection function void.
  - esp-mqtt commit: 67553ab
  - esp-mqtt MR: espressif/esp-mqtt!106
* Client: Removes unused defines
  - esp-mqtt commit: eec6f0e
  - esp-mqtt MR: espressif/esp-mqtt!100
  - Closes #194
* Config: Added support for certificate bundle
  - esp-mqtt commit: 06157be
  - esp-mqtt MR: espressif/esp-mqtt!98
  - Closes #190
* Config: Adds missing field at config struct (path field)
  - esp-mqtt commit: 5b27d18
  - esp-mqtt MR: espressif/esp-mqtt!96
* Client: Add support for partial transport writes
  - esp-mqtt commit: d8c9c7a
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Partially addresses espressif/esp-idf#6940
* Client: Add support for Retain flag in messages posted by events
  - esp-mqtt commit: a00a313
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Closes #193
* esp-mqtt: Added nullchecks for public APIs
  - esp-mqtt commit: 2f57985
  - esp-mqtt MR: espressif/esp-mqtt!94
  - Closes #185
* esp-mqtt: Reduce the includes used in all files
  - esp-mqtt commit: 87fcce7
  - esp-mqtt MR: espressif/esp-mqtt!93
* mqtt_outbox: Use STAILQ_FOREACH for outbox_delete_single_expired
  - esp-mqtt commit: ff8e648
  - esp-mqtt MR: espressif/esp-mqtt!97
  - Merges #187
* Client: Add optimize for depend on ssl
  - esp-mqtt commit: 8f3cac8
  - esp-mqtt MR: espressif/esp-mqtt!95
egnor pushed a commit to egnor/esp-mqtt that referenced this issue Dec 23, 2022
@david-cermak @egnor
MQTT: Support for certificate bundle; Client clean-up
8d5d3a2 
* Closes espressif/esp-idf#7040
* Merges espressif/esp-idf#7041
* Update submodule: git log --oneline 9fdf7b6..f10321a

Detailed description of the changes:
* Remove unnecessary parentheses
  - esp-mqtt commit: espressif@db13533
  - esp-mqtt MR: espressif/esp-mqtt!101
* outbox: Cleanup all items when connection closes
  - esp-mqtt commit: espressif@1a94efe
  - esp-mqtt MR: espressif/esp-mqtt!104
* Outbox: Removes unnecessary calls to outbox_set_pending
  - esp-mqtt commit: espressif@36a3990
  - esp-mqtt MR: espressif/esp-mqtt!105
* MQTT: Makes abort connection function void.
  - esp-mqtt commit: espressif@67553ab
  - esp-mqtt MR: espressif/esp-mqtt!106
* Client: Removes unused defines
  - esp-mqtt commit: espressif@eec6f0e
  - esp-mqtt MR: espressif/esp-mqtt!100
  - Closes espressif#194
* Config: Added support for certificate bundle
  - esp-mqtt commit: espressif@06157be
  - esp-mqtt MR: espressif/esp-mqtt!98
  - Closes espressif#190
* Config: Adds missing field at config struct (path field)
  - esp-mqtt commit: espressif@5b27d18
  - esp-mqtt MR: espressif/esp-mqtt!96
* Client: Add support for partial transport writes
  - esp-mqtt commit: espressif@d8c9c7a
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Partially addresses espressif/esp-idf#6940
* Client: Add support for Retain flag in messages posted by events
  - esp-mqtt commit: espressif@a00a313
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Closes espressif#193
* esp-mqtt: Added nullchecks for public APIs
  - esp-mqtt commit: espressif@2f57985
  - esp-mqtt MR: espressif/esp-mqtt!94
  - Closes espressif#185
* esp-mqtt: Reduce the includes used in all files
  - esp-mqtt commit: espressif@87fcce7
  - esp-mqtt MR: espressif/esp-mqtt!93
* mqtt_outbox: Use STAILQ_FOREACH for outbox_delete_single_expired
  - esp-mqtt commit: espressif@ff8e648
  - esp-mqtt MR: espressif/esp-mqtt!97
  - Merges espressif#187
* Client: Add optimize for depend on ssl
  - esp-mqtt commit: espressif@8f3cac8
  - esp-mqtt MR: espressif/esp-mqtt!95
egnor pushed a commit to egnor/esp-mqtt that referenced this issue Dec 23, 2022
@david-cermak @egnor
MQTT: Support for certificate bundle; Client clean-up
bd17b4e 
* Closes espressif/esp-idf#7040
* Merges espressif/esp-idf#7041
* Update submodule: git log --oneline 9fdf7b6..f10321a

Detailed description of the changes:
* Remove unnecessary parentheses
  - esp-mqtt commit: espressif@db13533
  - esp-mqtt MR: espressif/esp-mqtt!101
* outbox: Cleanup all items when connection closes
  - esp-mqtt commit: espressif@1a94efe
  - esp-mqtt MR: espressif/esp-mqtt!104
* Outbox: Removes unnecessary calls to outbox_set_pending
  - esp-mqtt commit: espressif@36a3990
  - esp-mqtt MR: espressif/esp-mqtt!105
* MQTT: Makes abort connection function void.
  - esp-mqtt commit: espressif@67553ab
  - esp-mqtt MR: espressif/esp-mqtt!106
* Client: Removes unused defines
  - esp-mqtt commit: espressif@eec6f0e
  - esp-mqtt MR: espressif/esp-mqtt!100
  - Closes espressif#194
* Config: Added support for certificate bundle
  - esp-mqtt commit: espressif@06157be
  - esp-mqtt MR: espressif/esp-mqtt!98
  - Closes espressif#190
* Config: Adds missing field at config struct (path field)
  - esp-mqtt commit: espressif@5b27d18
  - esp-mqtt MR: espressif/esp-mqtt!96
* Client: Add support for partial transport writes
  - esp-mqtt commit: espressif@d8c9c7a
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Partially addresses espressif/esp-idf#6940
* Client: Add support for Retain flag in messages posted by events
  - esp-mqtt commit: espressif@a00a313
  - esp-mqtt MR: espressif/esp-mqtt!99
  - Closes espressif#193
* esp-mqtt: Added nullchecks for public APIs
  - esp-mqtt commit: espressif@2f57985
  - esp-mqtt MR: espressif/esp-mqtt!94
  - Closes espressif#185
* esp-mqtt: Reduce the includes used in all files
  - esp-mqtt commit: espressif@87fcce7
  - esp-mqtt MR: espressif/esp-mqtt!93
* mqtt_outbox: Use STAILQ_FOREACH for outbox_delete_single_expired
  - esp-mqtt commit: espressif@ff8e648
  - esp-mqtt MR: espressif/esp-mqtt!97
  - Merges espressif#187
* Client: Add optimize for depend on ssl
  - esp-mqtt commit: espressif@8f3cac8
  - esp-mqtt MR: espressif/esp-mqtt!95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hasiflo @david-cermak