Disconnect message #106
Closed
Disconnect message #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SSL mutual authentication support
esp-mqtt announce integration to idf See merge request idf/esp-mqtt!6
david-cermak
requested changes
Mar 22, 2019
There was a problem hiding this comment.
The commit bdf7ec7 looks good to me, thanks!
But let me have two formal comments:
- please update your branches (+ rebase), so only your commit differs from top of the branch
- update your commit message with GitHub closing semantics ("closes Disconnect message #106" + the new one in idf repo)
|
Closed in favor of #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97 by implementing the disconnect message.