mqtt_client: fix esp_mqtt_client_enqueue for len=0 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 372b323 (mqtt_client: Fix mqtt send long data error, 2021-12-21) removed the length calculation from esp_mqtt_client_enqueue_priv and added it to esp_mqtt_client_publish. However, esp_mqtt_client_enqueue was missed. Currently calls to esp_mqtt_client_enqueue appear to send no data, fix this by adding the length calculation to esp_mqtt_client_enqueue.
david-cermak
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated esp-idf to latest master and saw a problem were messages sent with esp_mqtt_client_enqueue appeared to send but no data was seen. Bisecting pointed to commit 372b323 (mqtt_client: Fix mqtt send long data error, 2021-12-21).
The length calculation was removed from esp_mqtt_client_enqueue_priv and added to esp_mqtt_client_publish. However, it appears esp_mqtt_client_enqueue was missed. Currently calls to esp_mqtt_client_enqueue appear to send no data, fix this by adding the length calculation to esp_mqtt_client_enqueue.