fix #11 closing bracket conditional for c++ #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@marcogmaia Thank you for fix. LGTM |
|
Hi @marcogmaia Could you please also add header guards at the start of the file ? Of course, corresponding #endif at the end as well ? |
|
sure, when I get home I'll do it |
|
@prasad-alatkar All done. :) |
|
LGTM. @dhrishi PTAL |
dhrishi
approved these changes
May 29, 2020
|
@marcogmaia Thanks for the PR. This looks good! |
|
sry for closing/reopenning, I clicked "close" in the app thinking it would close the dialog |
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Aug 1, 2020
… (Backport v4.0) - Merges espressif/esp-nimble#12 - Fixes repeated pairing failure in RPA feature Closes #5530
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Aug 3, 2020
- Merges espressif/esp-nimble#12 - Fixes repeated pairing failure in RPA feature Closes #5530
projectgus
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Aug 7, 2020
… (Backport v4.2) - Merges espressif/esp-nimble#12 - Fixes repeated pairing failure in RPA feature Closes #5530
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Sep 10, 2020
… (Backport v3.3) - Merges espressif/esp-nimble#12 - Fixes repeated pairing failure in RPA feature Closes #5530
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Sep 10, 2020
… (Backport v4.1) - Merges espressif/esp-nimble#12 - Fixes repeated pairing failure in RPA feature Closes #5530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ble_hs_pvcy.h c++ closing bracket.