Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing definitions for standard-types (MEGH-3516) #126

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

sivar2311
Copy link
Contributor

Added missing standard-types from documentation.

@CLAassistant
Copy link

CLAassistant commented May 28, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Added missing definitions for standard-types Added missing definitions for standard-types (MEGH-3516) May 28, 2022
@sivar2311
Copy link
Contributor Author

Hello!

Are pull requests welcome? I opened one 11 days ago. Other PR are even older and they seem to be ignored.
I only ask because another PR in arduino-esp32 repository depends on this PR.

@shahpiyushv
Copy link
Collaborator

Sorry for the delay. As you can see, several changes were going on in the repository. We will get this merged asap.

@sivar2311
Copy link
Contributor Author

Thanks for the quick reply!
I am not that deep into this repository yet.
I am more active on the Arduino side.

@JohnMacrae
Copy link

JohnMacrae commented Jun 8, 2022 via email

@sivar2311
Copy link
Contributor Author

@JohnMacrae I haven't gotten that far yet. That's still on my to-do list.
At the moment I'm trying to understand the whole system and simplify it with a few ideas of my own.

@JohnMacrae
Copy link

@sivar2311 Ok - good luck. N.B. This problem has been ignored but still exists for me espressif/arduino-esp32#5420

@shahpiyushv
Copy link
Collaborator

@sivar2311 , can you once rebase your branch against master?

@sivar2311
Copy link
Contributor Author

@shahpiyushv Done :)

@espressif-bot espressif-bot merged commit 00bcf4c into espressif:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants