Feature/support sccb handle 16bit val #474
Conversation
|
@me-no-dev Some sensor registers need to read and write 16 bit values, so two APIs have been added. PTAL，Thanks. |
| if(ret != ESP_OK) { | ||
| ESP_LOGE(TAG, "W [%04x]=%04x fail\n", reg, data); | ||
| } | ||
| return ret == ESP_OK ? 0 : -1; |
There was a problem hiding this comment.
Maybe switch return type to esp_err_t, because currently you have it as uint8_t, but here you are returning -1
There was a problem hiding this comment.
I guess this would need to be done for the other write methods as well
There was a problem hiding this comment.
The current sensor driver code has many expressions similar to if(SCCB_Write() < 0), so although the return value type can be defined as esp_err_t in the function declaration, in the relevant code, we only check whether the return value of the function is less than 0. Therefore, there are two options.
- We only define the return value type of the function as
esp_err_tin the function declaration, and do not really return the return value of thei2c_master_cmd_begin(). - Or we can directly define the return value of this function as type
int.
There was a problem hiding this comment.
in that case, using int or int8_t would also do the job
There was a problem hiding this comment.
The return value of sccb_write() has been changed to type int.
There was a problem hiding this comment.
@me-no-dev ,At present, it is not easy to buy some cameras that support JPEG encoding. A new sensor driver can work normally, but the current submission is required. If there is no problem, please help merge the submission. We will submit the driver code of the new camera as soon as possible. thanks.
|
It's in :) |
No description provided.