New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: deploy to Github Pages #55
Conversation
@balloob thanks for noticing this! I have updated the workflow to run The new version still doesn't work quite as well as the one in gh-pages branch, though. With this version, connecting to an ESP32-C3:
With the version in gh-pages:
@brianignacio5 are you seeing any similar issue in the |
I've tried with ESP32-C3 but I couldn't also connect. I suspect is something related with the |
I'm getting the same with ESP32 connected over an FT2232-H USB bridge
The version in the gh-pages branch works fine for the same board. |
I think these PRs look okay, the changes will affect only the flashing stage and not the initial connection/sync stage. Might be a regression from the typescript rewrite? I guess we need to compare the data set to/from the chip by the version in gh-pages and by the version in |
I'm trying to find the reason why the TS rewrite fails. I think it's because timeout error handling and MD5 calculation error but it is hard to understand the issue because I don't know about expected data. Can someone help to test to record the data from gh-pages to compare with main branch ? |
Since the package is currently in a broken state, can we revert the TypeScript rewrite until the issue is found? |
Is there a time line when will be worked on the known bugs? |
The issue was calling I then just removed calling |
Seems to work okay now with the fix from @domagojk (thanks again! 🙏 ), so I'll merge this. There are still a few minor issues compared to the gh-pages branch, like slightly messier logs, but we can fix that in a separate PR. |
Similar to espressif/esp-launchpad#4, adds a CI job to deploy the latest version from
main
branch to Github Pages. With this PR, we don't need to maintain gh-pages branch manually.Have tested this workflow in a fork, deployment was successful: https://igrr.github.io/esptool-js/.