fix: timeout error on connecting #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domagojk Thank you for finding the issue and submitting the fix! |
|
As a result of this change, we are now seeing this error for the first time on our C3. Flushed cache and all. |
|
@NikitaUT Oops, sorry about that! Could you please open a new issue, attaching the terminal output you get? If you manually put the chip into download mode, do you get the same behavior? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported in #55 #58
In a version used in gh-pages, there was a typo:
readRawinstead ofrawReadbut since it was try/catched, the error didn't show up.In typescript update, typo was fixed, but that caused a timeout issue.
Not sure, if it should just be deleted or it should be used differently.