Stub already running detection #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Apr 2, 2024
| @@ -1140,6 +1146,11 @@ export class ESPLoader { | |||
| * @returns {ROM} The Chip ROM | |||
| */ | |||
| async runStub(): Promise<ROM> { | |||
| if (this.syncStubDetected) { | |||
There was a problem hiding this comment.
Can we verify that the version of the stub that's running is the same as the version that we would upload ?
There was a problem hiding this comment.
Not according to what the stub_flasher code does here
https://github.com/espressif/esptool/blob/master/flasher_stub/stub_flasher.c#L240
There was a problem hiding this comment.
Fair, this follows the esptool.py approach 👍
There was a problem hiding this comment.
Any chance this can be merged? This is the last piece of work that the ExpressLRS project needs for it's web-flasher to be on the mainline of esptool-js.
|
LGTM Thanks for the contribution |
Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the code from the python version of esptool that detects if the stub flasher is already running. If the stub is already running, the stub upload is no longer performed.