workaround for bug in SPIEraseArea #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a cleaner rewrite of the code in bug #33 by iggr. Also added a fake flash_begin so flash_finish returns sucessfully.
|
I'm curious if the behavior for DIO from #52 should actually be used as the default? |
|
FYI, I did some analysis on how and why this fix works: https://cesanta.com/blog/esp8266-flash-erasing-issue.shtml |
|
After debugging for hours, this solved my issue. Please accept this pull request and save future me's the hassle! |
|
@themadinventor poke |
This was referenced Aug 30, 2015
Closed
Closed
projectgus
added a commit
that referenced
this pull request
Sep 2, 2015
Float argument strayed into flash_begin() size, caused erase sizes to be calculated as too long. This triggered an error when writing near the end of the flash, it would ask for erasing beyond the end of available space. Closes #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner rewrite of the code in bug #33 by iggr. Also added a fake flash_begin so flash_finish returns sucessfully. See also #48 and #51.