IEP-720: Fix for python script errors #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alirana01 hi ! Tested under: Test case: go to esp-idf/tools folder -> change idf_tools.py with some mistake -> run " Install Tools" -> go to "Window"->Preferences->C/C++ -> Build -> Environment -> See logs: before: after: LGTM 👍 |
|
Hi @alirana01 Could you please fix the conflicts and merge this PR |
- Updated and refactored code to return status from commands execution method. - Added a job change listener to look for error status from job - Added the ability to revert back to old env vars incase of failures Existing flows and with errors are working fine but it still needs to be tested on Linux and Mac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing flows and with errors are working fine but it still needs to be tested on Linux and Mac