Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEP-815: openocd path in the Espressif preferences page requires the eclipse restart to update a value #639

Merged
merged 1 commit into from Dec 13, 2022

Conversation

sigmaaa
Copy link
Collaborator

@sigmaaa sigmaaa commented Dec 6, 2022

Description

Updating the default value for openocd path immediately after tools installation.

Fixes # (IEP-815)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Test 1:

  • Make sure, that openocd can be updated (the latest version is not yet installed). To do it:
    Go to Preferences -> Espressif -> Global OpenOCD Path

Screenshot 2022-12-06 at 13 52 35

  • Now install tools from the latest esp-idf master. After the installation the Global OpenOCD Path should be updated:

Screenshot 2022-12-06 at 13 56 38

Test 2: - Create a debug configuration and check if Actual executable value is updated accordingly.

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Espressif Preference Page
  • Debugger Tab

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link
Collaborator

@kolipakakondal kolipakakondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiFilippov
Copy link
Collaborator

@sigmaaa hi !

Tested under:
OS: Windows 10
ESP-IDF: master

Test 1:

Make sure, that openocd can be updated (the latest version is not yet installed). To do it:
Go to Preferences -> Espressif -> Global OpenOCD Path
image

Now install tools from the latest esp-idf master. After the installation the Global OpenOCD Path should be updated:

image

Test 2: - Create a debug configuration and check if Actual executable value is updated accordingly.

image

LGTM

@kolipakakondal kolipakakondal merged commit 2c25598 into master Dec 13, 2022
@kolipakakondal kolipakakondal deleted the IEP-815 branch December 13, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants