Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IEP-1089 , IEP-1062: Project Creation Page updated #846

Merged
merged 12 commits into from
Nov 22, 2023
Merged

IEP-1089 , IEP-1062: Project Creation Page updated #846

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7b2eb1d
IEP-1089: Updated the project creation wizard to have only one page w…
alirana01 Nov 2, 2023
dbb9ea6
Fix for project ui tests for new ui
alirana01 Nov 2, 2023
692bc3f
Minor code review things from the coderabbitai review
alirana01 Nov 2, 2023
2a61f62
added the esp target selection to the project
alirana01 Nov 6, 2023
177aeb5
unwanted import removed
alirana01 Nov 6, 2023
001a800
Updated UI for the grouped templates
alirana01 Nov 8, 2023
1601a97
fixed issue related to hidden control on some UIs
alirana01 Nov 8, 2023
68a9caa
review comments for code improvement
alirana01 Nov 8, 2023
71e9020
fix for the finish button
alirana01 Nov 13, 2023
d710d91
updated to handle the finish button and target change bug
alirana01 Nov 14, 2023
787fccd
improved the job join
alirana01 Nov 14, 2023
70b89b0
coderabbit review comments resolved
alirana01 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...m.espressif.idf.ui/src/com/espressif/idf/ui/templates/AbstractTemplatesSelectionPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ public void createControl(Composite parent)
container.setLayoutData(new GridData(GridData.FILL_BOTH));

createAbove(container, 1);
if (templateElements == null || templateElements.getChildren().isEmpty())
{
Dialog.applyDialogFont(container);
setControl(container);
return;
}
alirana01 marked this conversation as resolved.
Show resolved Hide resolved

Label label = new Label(container, SWT.NONE);
label.setText(getLabel());
GridData gd = new GridData();
Expand All @@ -107,7 +114,10 @@ public void createControl(Composite parent)
templateViewer.addDoubleClickListener(event -> doubleClickAction.run());
createDescriptionIn(sashForm);
createBelow(container, 1);
templateViewer.setInput(templateElements);
if (templateElements != null && !templateElements.getChildren().isEmpty())
{
templateViewer.setInput(templateElements);
}
initializeViewer();
templateViewer.addSelectionChangedListener(this);

Expand Down
6 changes: 4 additions & 2 deletions bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/templates/Messages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ public class Messages extends NLS
public static String BaseWizardSelectionPage_No_Desc;
public static String TemplateListSelectionPage_SelectTemplate_Desc;
public static String TemplateListSelectionPage_Template_Wizard_Desc;
public static String TemplateListSelectionPage_Templates;
public static String TemplateListSelectionPage_Templates_Desc;
public static String NewProjectWizardPage_Header;
public static String NewProjectWizardPage_DescriptionString;
public static String TemplateSelectionToolTip;
public static String NewProjectWizardPage_NoTemplateFoundMessage;

static
{
// initialize resource bundle
Expand Down
Loading
Loading