Add ESP8685-WROOM-06 schematic symbol and footprint #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README to add missing ESP8685-WROOM parts
pedrominatel
added
new symbol
pedrominatel
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Hi @tbeckley, thank you for your contribution.
Can you check the following items?
- Check the thermal pad measurements (see picture)
- Move the coordinate origins to the center of the shield (close to x 7.9 and y -10)
|
Thanks for the review! I knew those stacked dimensions would get me. I have made the changes as requested. |
|
Thank you, @tbeckley.
|
pedrominatel
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to create this for a project so here's some good citizenry. Also update README to add missing ESP8685-WROOM parts.
Hope I got all the tiny little dimensions right.