fix the KLC S4.2 for all symbols #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @dreamcmi. Thank you for your contribution. I'll take a look ASAP. |
|
Hi @pedrominatel, I have tested the library with KiCad 7 release. |
|
Hi @dreamcmi Can you fix the conflicts? |
…lc_s4.2 and fix esp32-c6-mini-1 esp32-c6-wroom-02 klc problem # Conflicts: # libraries/Espressif.kicad_sym
|
Hi @pedrominatel |
pedrominatel
reviewed
Mar 2, 2023
| (name "GND" (effects (font (size 1.27 1.27)))) | ||
| (number "2" (effects (font (size 1.27 1.27)))) | ||
| ) | ||
| (pin bidirectional line (at 27.94 0 180) (length 2.54) | ||
| (name "GPIO15" (effects (font (size 1.27 1.27)))) | ||
| (number "20" (effects (font (size 1.27 1.27)))) | ||
| ) | ||
| (pin no_connect line (at -27.94 -10.16 0) (length 2.54) |
There was a problem hiding this comment.
This pin should be set as hide
| @@ -1068,107 +1073,107 @@ | |||
| (name "U0TXD/GPIO16" (effects (font (size 1.27 1.27)))) | |||
| (number "31" (effects (font (size 1.27 1.27)))) | |||
| ) | |||
| (pin no_connect line (at -27.94 -12.7 0) (length 2.54) | |||
There was a problem hiding this comment.
This pin should be set as hide as all NCs
| @@ -1269,7 +1274,7 @@ | |||
| (name "GPIO23" (effects (font (size 1.27 1.27)))) | |||
| (number "21" (effects (font (size 1.27 1.27)))) | |||
| ) | |||
| (pin no_connect line (at -27.94 -12.7 0) (length 2.54) | |||
|
Done, please review. |
pedrominatel
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix KLC S4.2 for all current symbols, but may be still has some errors, please review.
#71