Skip to content

Commit

Permalink
[Clang][IFS][Test] Work around in-process cc1 ASAN issues #2.
Browse files Browse the repository at this point in the history
Using the same strategy as c38e425.

D69825 revealed (introduced?) a problem when building with ASan, and
some memory leaks somewhere. More details are available in the original
patch.

Looks like we missed one failing tests, this patch adds the workaround
to this test as well.

(cherry picked from commit e174da4)
  • Loading branch information
hctim authored and zmodem committed Jan 23, 2020
1 parent 2dd6b91 commit bfaba51
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions clang/test/Driver/cl-showfilenames.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,19 @@
// target Windows.
// REQUIRES: x86-registered-target

// RUN: %clang_cl --target=i686-pc-win32 /c /Fo%T/ /showFilenames -- %s 2>&1 | FileCheck -check-prefix=show %s
// RUN: %clang_cl --target=i686-pc-win32 /c /Fo%T/ /showFilenames -- %s %S/Inputs/wildcard*.c 2>&1 | FileCheck -check-prefix=multiple %s
// NOTE: -fno-integrated-cc1 has been added to work around an ASAN failure
// caused by in-process cc1 invocation. Clang InterfaceStubs is not the
// culprit, but Clang Interface Stubs' Driver pipeline setup uncovers an
// existing ASAN issue when invoking multiple normal cc1 jobs along with
// multiple Clang Interface Stubs cc1 jobs together.
// There is currently a discussion of this going on at:
// https://reviews.llvm.org/D69825

// RUN: %clang_cl --target=i686-pc-win32 /c /Fo%T/ -- %s 2>&1 | FileCheck -check-prefix=noshow %s
// RUN: %clang_cl --target=i686-pc-win32 /c /Fo%T/ /showFilenames /showFilenames- -- %s 2>&1 | FileCheck -check-prefix=noshow %s
// RUN: %clang_cl -fno-integrated-cc1 --target=i686-pc-win32 /c /Fo%T/ /showFilenames -- %s 2>&1 | FileCheck -check-prefix=show %s
// RUN: %clang_cl -fno-integrated-cc1 --target=i686-pc-win32 /c /Fo%T/ /showFilenames -- %s %S/Inputs/wildcard*.c 2>&1 | FileCheck -check-prefix=multiple %s

// RUN: %clang_cl -fno-integrated-cc1 --target=i686-pc-win32 /c /Fo%T/ -- %s 2>&1 | FileCheck -check-prefix=noshow %s
// RUN: %clang_cl -fno-integrated-cc1 --target=i686-pc-win32 /c /Fo%T/ /showFilenames /showFilenames- -- %s 2>&1 | FileCheck -check-prefix=noshow %s


#pragma message "Hello"
Expand Down

0 comments on commit bfaba51

Please sign in to comment.