Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the extension on Open VSX (VSC-364) #125

Closed
Leonardobat opened this issue Jun 14, 2020 · 4 comments
Closed

Publish the extension on Open VSX (VSC-364) #125

Leonardobat opened this issue Jun 14, 2020 · 4 comments
Assignees
Labels
Feature / Enhancement Request Request for Feature/ Enhancement wontfix This will not be worked on

Comments

@Leonardobat
Copy link

I'm a VS Codium user, a FLOSS version of VS Code, it's the same code but without the Microsoft's telemetry and branding.
I want to request if possible to add the Espressif extension on the open-vsx.org market to us doesn't need to works with the Microsoft marketplace as is unclear if it's legal to use it on VS Code forks, see here.

Additional info:

  • This is how to publish a new extension.
  • I know your extension relies on C++ Microsoft extension, one possible workaround would use the Clangd ones.
  • I know too that your main compiler is GCC, but as there is an LLVM port in process and the clangd extension has no debug feature, would be only necessary to resolve all the #include stuff.
@github-actions github-actions bot changed the title Publish the extension on Open VSX Publish the extension on Open VSX (VSC-364) Jun 14, 2020
@pwmb pwmb added the Feature / Enhancement Request Request for Feature/ Enhancement label Jun 14, 2020
@pwmb pwmb added this to the Feature Backlog Candidate milestone Jun 14, 2020
@pwmb pwmb self-assigned this Jun 14, 2020
@pwmb
Copy link
Contributor

pwmb commented Jun 14, 2020

@Leonardobat did you tried to run the .vsix from the Release Tab and see if it works at all ?

Its true that we use c/c++ Extension from Microsoft as ESP-IDF's language server for intellisense but features like build/flash/monitor/menuconfig, etc., should work without the c/c++ extension itself.

If .vsix install fails, I would suggest you to build one .vsix after cloning the repo and modifying the package.json's content

From:

"extensionDependencies": [
  "ms-vscode.cpptools"
],

To:

"extensionDependencies": [],

Steps to build vsix locally can be found here, but here is the quick steps for you:

  • Clone this repo
  • Install Nodejs
  • Install yarn
  • Run yarn install to install dependencies in the root of the cloned repo
  • Run yarn package to generate a vsix file

Please do let us know your findings.

Also a side note, if you want to remove the telemetry from vscode you can follow this guide

@Leonardobat
Copy link
Author

Thanks for the reply @pwmb.
Just install your .vsix, won't work as it is dependent on Microsoft's extension. Instead, build locally without the dependency, the building, flashing, monitor and the menu config features worked well.

@pwmb
Copy link
Contributor

pwmb commented Jun 15, 2020

Thanks @Leonardobat for testing this out... We will test release process to the openvsx marketplace, and let you know.

@pwmb pwmb added the ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot label Jun 15, 2020
@pwmb pwmb added wontfix This will not be worked on and removed ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot labels Sep 9, 2020
@pwmb
Copy link
Contributor

pwmb commented Sep 9, 2020

Since we still depends on ms-vscode.cpptools extension for several tasks, can't release a fully functional extension in open-vsx marketplace.

In future once we have no dependency on the ms-vscode.cpptools extension we could proceed with the release, till then will close this issue.

@pwmb pwmb closed this as completed Sep 9, 2020
@pwmb pwmb removed this from the Feature Backlog Candidate milestone Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature / Enhancement Request Request for Feature/ Enhancement wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants