Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/migrate vue3 #1035

Merged
merged 56 commits into from Jan 19, 2024
Merged

Enhance/migrate vue3 #1035

merged 56 commits into from Jan 19, 2024

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Sep 6, 2023

Description

Update web views from Vue 2 and vuex to Vue 3 and Pinia because vue 2 support will be dropped the end of this year.

Fix #1051 Added search for ESP-IDF: Show Examples command

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Steps to test this pull request

This PR is very big and many features need to be tested. Basically all web views under src/views

  1. Right click a CMakeLists.txt file and select ESP-IDF: CMakeLists.txt editor command. If the file is root directory choose Project Project CMakeLists.txt otherwise choose Component CMakeLists.txt. Use UI to modify values and see changes on CMakeLists.txt. Run Developer: Open web view Developer tools and see if there is any error in the console.
  2. Execute ESP-IDF: Show examples projects. Choose example, check rendered markdown view, create project. Run Developer: Open web view Developer tools and see if there is any error in the console.
  3. Execute ESP-IDF: SDK Configuration editor (menuconfig) command. Modify different kind of values like number, string, hex, checkbox, select dropdown. Check the ESP-IDF output for any error. Run Developer: Open web view Developer tools and see if there is any error in the console.
  4. Execute ESP-IDF: New Project command. Modify all options, Try to add a local component, choose template and create a project. Run Developer: Open web view Developer tools and see if there is any error in the console.
  5. Open an example with NVS data like Protocols -> http_server -> file_serving. Right click nvs_data.csv and select ESP-IDF: Open NVS Partition editor. add, Modify or remove values and types and click the different action buttons. Run Developer: Open web view Developer tools and see if there is any error in the console.
  6. Open an example with Partition table data like Protocols -> http_server -> file_serving. Right click partitions_example.csv and select ESP-IDF: Open Partition table editor UI. add, Modify or remove values and types and click the different action buttons. Run Developer: Open web view Developer tools and see if there is any error in the console.
  7. Open an example with multiple configuration like Build system -> CMake -> multi_config and follow the multiple config tutorial Run Developer: Open web view Developer tools and see if there is any error in the console.
  8. Run the ESP-IDF: Configure ESP-IDF extension command and run the 3 kinds of setup from UI: Express Advanced and use existing setup. Run Developer: Open web view Developer tools and see if there is any error in the console.
  9. Follow the app tracing tutorial to test the Application tracing. Run Developer: Open web view Developer tools and see if there is any error in the console.
  10. Follow the heap tracing tutorial to test the Heap Tracing. Run Developer: Open web view Developer tools and see if there is any error in the console.
  11. Run the ESP-IDF: Welcome to open the extension welcome page and test all links and buttons. Run Developer: Open web view Developer tools and see if there is any error in the console.
  • Expected behaviour:

  • Expected output:

How has this been tested?

Manual testing of each view

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

src/views/system-view/plot.ts Fixed Show fixed Hide fixed
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
@brianignacio5 brianignacio5 marked this pull request as ready for review September 26, 2023 14:50
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 self-assigned this Sep 27, 2023
@brianignacio5 brianignacio5 added this to the v1.7.0 milestone Sep 27, 2023
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments for small left overs. Also, the things found by code scanner should be addressed before merging

src/espIdf/tracing/system-view/panel.ts Outdated Show resolved Hide resolved
src/views/commons/espCommons.scss Outdated Show resolved Hide resolved
src/views/nvs-partition-table/components/Row.vue Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 8, 2023

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Nov 8, 2023
@radurentea radurentea added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Nov 8, 2023
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
src/views/system-view/plot.ts Fixed Show fixed Hide fixed
@AndriiFilippov

This comment was marked as resolved.

@AndriiFilippov

This comment was marked as resolved.

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi!

  1. I think we should add default (namespace) nvs row, like this:
    image

because it is fully empty now.
we have it in IDE:
image

  1. For Type : namespace - lets delete drop-down window because it is empty field(confusing):
    image

@AndriiFilippov

This comment was marked as resolved.

@kolipakakondal
Copy link
Collaborator

kolipakakondal commented Nov 21, 2023

@brianignacio5 hi! Tested: OS - Windows 10

Shouldn't this text be active link ? caz when I put cursor on this text - it reacts, but I can't click it

image

Please show all hyper links text in the blue color. Example -
Screenshot 2023-11-21 at 2 19 06 PM

@AndriiFilippov

This comment was marked as resolved.

@AndriiFilippov

This comment was marked as resolved.

@AndriiFilippov

This comment was marked as resolved.

@AndriiFilippov

This comment was marked as resolved.

@brianignacio5
Copy link
Collaborator Author

Fixed all commented issues @AndriiFilippov PTAL when you can

@AndriiFilippov

This comment was marked as resolved.

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

Tested under:
OS - Windows 10
ESP-IDF: v5.1.2

LGTM 👍

@brianignacio5 brianignacio5 merged commit 0873746 into master Jan 19, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the enhance/migrate-vue3 branch January 19, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: add filtering for esp-idf examples wizrd (VSC-1197)
4 participants