Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add boards filtered by idf target #1079

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

brianignacio5
Copy link
Collaborator

Description

Filter OpenOCD board by IDF_TARGET

Fixes VSC-1240

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "Select OpenOCD Board configuration"
  2. Execute action.
  3. Observe results. Should only see board by current IDF_TARGET
  • Expected behaviour:

  • Expected output:

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Nov 16, 2023
Copy link

Download the artifacts for this pull request:

Copy link
Collaborator

@kolipakakondal kolipakakondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brianignacio5 , this is a good enhancement.

Screenshot 2023-11-20 at 6 57 42 PM

With this, the order will also be changed.

@kolipakakondal kolipakakondal added the enhancement New feature or request label Nov 20, 2023
@kolipakakondal kolipakakondal added this to the v1.7.0 milestone Nov 20, 2023
@kolipakakondal
Copy link
Collaborator

Hi @AndriiFilippov Please verify

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

If I try to create project without OpenOCD confgi file -> the the "create project using template 'hello world' button does not work, no notification\warning at all.

image

image

@brianignacio5
Copy link
Collaborator Author

Sorry @AndriiFilippov but I'll fix this issue in the #1013 too because is not related to the changes in this PR.

Have you tested the ESP-IDF: Select OpenOCD Board configuration command to see changes here ?

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

UI update: please, make this window static:

image

@brianignacio5
Copy link
Collaborator Author

@brianignacio5 hi !

UI update: please, make this window static:

image

Fixed in 8641278

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

LGTM 👍

@brianignacio5 brianignacio5 merged commit 00198dc into master Dec 19, 2023
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/filtered-boards branch December 19, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants