Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate python list add win compilerPath #1084

Merged
merged 1 commit into from Jan 8, 2024

Conversation

brianignacio5
Copy link
Collaborator

Description

Make sure python paths list does not have duplicated in ESP-IDF: Configure ESP-IDF extension command.

Fix c_cpp_properties.json compilerPath command on Windows replacement when IDF_TARGET is changed.

Fixes #1083

Fixes #1073

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Configure ESP-IDF extension" and check that there is no duplicated python paths in the dropdown list.
  2. Change IDF_TARGET using the ESP-IDF: Set Espressif device target command. Observe that compilerPath field in c_cpp_properties.json is updating with correct ${config:idf.toolsPathWin}\... on Windows and ${config:idf.toolsPath}/... on others.
  • Expected behaviour:
  • no duplicated python paths in the dropdown list in Setup wizard
  • c_cpp_properties.json compilerPath is updated with correct path for toolchain path.
  • Expected output:

How has this been tested?

Manual testing on Windows 10.

Test Configuration:

  • ESP-IDF Version: 5.1
  • OS (Windows,Linux and macOS): Windows

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added the bugfix Fixing some issue and bug in this PR label Nov 24, 2023
@brianignacio5 brianignacio5 added this to the v1.7.0 milestone Nov 24, 2023
@brianignacio5 brianignacio5 self-assigned this Nov 24, 2023
Copy link

Download the artifacts for this pull request:

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Dec 10, 2023
@brianignacio5 brianignacio5 removed the stale Stale PR or Issue label Dec 11, 2023
@AndriiFilippov
Copy link
Collaborator

AndriiFilippov commented Dec 22, 2023

@brianignacio5 hi !

Tested under:
OS - Windows 10 / MacOS
ESP-IDF: v5.1.1

Does not see python paths list have any duplicated in ESP-IDF: Configure ESP-IDF extension command.
Change target -> do see correct '${config:idf.toolsPathWin}'on Windows and '${config:idf.toolsPath}' on others.

LGTM 👍

Copy link

github-actions bot commented Jan 7, 2024

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Jan 7, 2024
@brianignacio5 brianignacio5 removed the stale Stale PR or Issue label Jan 8, 2024
@brianignacio5 brianignacio5 merged commit b3d0758 into master Jan 8, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/duplicated-py-paths-in-list branch January 8, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
3 participants