Fix for issue #1092 (VSC-1257) #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…extension # Conflicts: # src/idfToolsManager.ts # src/utils.ts
|
Thank you for your PR. Could you please fix the lint issues so we can merge this changes ? |
github-actions
bot
changed the title
I believe I just did that by running |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Fixes #1092
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Configure extension with the existing ESP-IDF + installed tools on Windows 11, there should be no errors complaining that the tools are not found at the specified correct paths
How has this been tested?
This has been tested on my VSCode with the existing ESP-IDF + installed tools on Windows 11
Dependent components impacted by this PR:
Checklist