remove ccpp extension dependency #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianignacio5
added
enhancement
|
Download the artifacts for this pull request: |
radurentea
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove Microsoft C/C++ extension from vscode extension dependencies. This will simplify release flow for vsix for open-vsx and vscode marketplace release. Allow user to define their own language extensions since we don't provide support for them.
Fix #672
Type of change
Steps to test this pull request
Test
yarn packagein CLI to try to build this extension. Follow Build from source or CONTRIBUTING.md tutorial. Observe Microsoft C/C++ extension is not added automatically as before.Expected behaviour: No C/C++ extension dependency required.
Expected output:
How has this been tested?
Manual testing in macOS build from source.
Test Configuration:
Dependent components impacted by this PR:
Checklist