Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing idf targets #1112

Merged
merged 1 commit into from
Jan 25, 2024
Merged

add missing idf targets #1112

merged 1 commit into from
Jan 25, 2024

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Jan 11, 2024

Description

Add ESP32 C2 ESP32 H2 Targets

Fixes #XXX

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Set Espressif device target"
  2. Execute action. Check that selected target for ESP32H2 or ESP32C2 are set in settings.json and no errors found.
  3. Observe results.
  • Expected behaviour:

  • Expected output:

How has this been tested?

Manual test of ESP-IDF: Set Espressif device target command.

Test Configuration:

  • ESP-IDF Version: 5.1
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Jan 11, 2024
Copy link

Download the artifacts for this pull request:

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 added this to the v1.7.0 milestone Jan 23, 2024
@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

Tested under:
OS - Windows 10
ESP-IDF: v5.1.2

able to select targets (C2 / H2) -> build -> flash -> monitor 👍
settings.json file looks good, do not see any errors.

LGTM 👍

@brianignacio5 brianignacio5 merged commit 71784fe into master Jan 25, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/missing-targets branch January 25, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants