New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix python venv install wheel issue in Linux (VSC-348) #113
🐛 Fix python venv install wheel issue in Linux (VSC-348) #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@an-dr could you give it a try and see if this fixes your problem ?
It seems not solved for me. and even a bit more broken then it was) For python 2
For python3
|
This seems to be related to the shell executable being used. Isn't it |
@brianignacio5 right now, |
@brianignacio5 using the full and on python 2.7 I'm getting
|
@brianignacio5 using a full path with Python 3.8
|
Just to be clear, using of |
Oh yes, we don't support Thanks will give a try and validate ~ (maybe add some replacement method) |
@brianignacio5 is it expected behavior with IDF_PATH? |
From export.sh it can sort of resolve using its current directory but the Windows installer got a fix for this on December 2019 looking at some esp-idf issues. It's probably because is only on latest esp-idf version no one has reported this yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside new issues with IDF_PATH
and ~
works for me
* Add ws package * Add initial idf_monitor ws based communication lib * Add monitor terminal with ws param * Release/v0.3.0 (VSC-366) (#127) * 🐛 Fix the wrong start icon for heap tracing * v0.3.0 Added to changelog * Fix the format in readme * Update ESP_RAINMAKER.md (#130) * Fix the IDF Size UI Bar Size Issue (VSC-368) (#129) * 🐛 Fix the wrong start icon for heap tracing * 🐛 Fix the IDF Size UI issue * 🐛 Fix the focus color for button * 🚨 Fix the lint error * 🐛 Fix python venv install wheel issue in Linux (VSC-348) (#113) * add venv install wheel * add ~ validation and IDF_PATH on py reqs install * v0.3.0 * Remove Monitor Type * Remove the type defination for MonitorType * Add option to select port from user input Co-authored-by: Brian A. Ignacio <brian@espressif.com>
* Add ws package * Add initial idf_monitor ws based communication lib * Add monitor terminal with ws param * Release/v0.3.0 (VSC-366) (#127) * 🐛 Fix the wrong start icon for heap tracing * v0.3.0 Added to changelog * Fix the format in readme * Update ESP_RAINMAKER.md (#130) * Fix the IDF Size UI Bar Size Issue (VSC-368) (#129) * 🐛 Fix the wrong start icon for heap tracing * 🐛 Fix the IDF Size UI issue * 🐛 Fix the focus color for button * 🚨 Fix the lint error * 🐛 Fix python venv install wheel issue in Linux (VSC-348) (#113) * add venv install wheel * add ~ validation and IDF_PATH on py reqs install * v0.3.0 * Remove Monitor Type * Remove the type defination for MonitorType * Add option to select port from user input * Create core-dump elf file * Add i18n for the command description * Add launch debugger after elf is generated * 🐛 Fix the elf file path issue * Update package.json * When debug is terminated stop the Websocket server * Fix the scheme file issues Co-authored-by: Brian A. Ignacio <brian@espressif.com>
* add arguments to debug adapter manager (VSC-379) (#139) * add arguments to debug adapter manager * rm unused launch prop rename initGdbCommands * create gdbinit from initGdbCommands launch arg * add coredump file arg update cmdfile * add gdbinit launch arg catch debug session error * use values from ws response * add option to build and flash when no elf found * no oocd on coredumpfile arg * check dbgAdapterMng current workspace * test using gabriel xvfb * try redirect test output * fix env var test * try old ci * see errors on ci log * try with tee * us xvfb action for cleanup * mv test args to package json * add extension requirements.txt * rm check isPostMortemMode required Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com> * Core dump integration with vscode (VSC-378) (#138) * Add ws package * Add initial idf_monitor ws based communication lib * Add monitor terminal with ws param * Release/v0.3.0 (VSC-366) (#127) * 🐛 Fix the wrong start icon for heap tracing * v0.3.0 Added to changelog * Fix the format in readme * Update ESP_RAINMAKER.md (#130) * Fix the IDF Size UI Bar Size Issue (VSC-368) (#129) * 🐛 Fix the wrong start icon for heap tracing * 🐛 Fix the IDF Size UI issue * 🐛 Fix the focus color for button * 🚨 Fix the lint error * 🐛 Fix python venv install wheel issue in Linux (VSC-348) (#113) * add venv install wheel * add ~ validation and IDF_PATH on py reqs install * v0.3.0 * Remove Monitor Type * Remove the type defination for MonitorType * Add option to select port from user input * Create core-dump elf file * Add i18n for the command description * Add launch debugger after elf is generated * 🐛 Fix the elf file path issue * Update package.json * When debug is terminated stop the Websocket server * Fix the scheme file issues Co-authored-by: Brian A. Ignacio <brian@espressif.com> * Fix the env problem * Add config before requesting launch * add requirements validation * fix requirements files check Co-authored-by: Brian A. Ignacio <brian@espressif.com>
For Python > 3.3, we use
venv
since it the official Python virtual environments module. The thing is, for Linux users it seems to not includewheel
from the system wide Python within the virtual environment.We added an step to install wheel in the virtualenv before installing requirements.txt
Should fix #105