Added a custom Debug Adapter (VSC-250) #45

an-dr · 2020-02-20T08:44:36Z

Added support of debugging using DAP-compatible debug adapter

README.md

esp_debug_adapter/README.md

esp_debug_adapter/debug_adapter/cli.py

esp_debug_adapter/debug_adapter/debug_backend/debug_backend/hw_spec_tools.py

requirements.txt

src/test/adapter.test.ts

templates/fibonacci-app/main/CMakeLists.txt

templates/.vscode/settings.json

an-dr · 2020-02-24T12:16:12Z

@brianignacio5 after rebasing to 0.1.3 I've faced with several issues, need your participation. I will describe them bellow. Thanks!

an-dr · 2020-02-24T12:20:12Z

If there is no Openocd in the Path - silently do nothing

an-dr · 2020-02-24T12:21:19Z

While debugging getting

and after this debugger ceases to reply to step, continue and other buttons

an-dr · 2020-02-24T12:29:28Z

Previosly I used ${config:idf.openOcdBin}/${config:idf.openOcdBinWin} and ${config:idf.openOcdScriptsPath}/${config:idf.openOcdScriptsPathWin} to launching adapter manually from tasks.json. Could you advice to which parameters it is better to change them now?

brianignacio5 · 2020-02-25T05:56:52Z

Hey @an-dr I've just made a PR to your repo with some changes in vscode part.

I took your PR, rebase it to current master in this repo, and add some changes.

Please take a look in an-dr#1

I tried to plug a build and flash before debug (thereby this error on debug) which was working on MacOS but is not working for you or me in Ubuntu. Will remove for now and think about solutions for it later.

With regards to ${config:idf.openOcdScriptsPath}/${config:idf.openOcdScriptsPathWin} we replaced it with ${config:idf.customExtraPaths} as shown in the tasks.json in the mentioned PR.

Let me know further steps.

Fix/use new configs

an-dr · 2020-02-25T09:29:09Z

@brianignacio5 works now! Testing remained. Can't see if I can do anything to fix this

  <testsuite name="initialize" timestamp="2020-02-25T09:26:38" tests="1" file="c:\esp\github\vscode-esp-idf-extension\d                                  ebug-adapter\out\test\suite\adapter.test.js" time="0.0000" failures="1">
    <testcase name="Debug Adapter Tests initialize should return supported features" time="0.0000" classname="should re                                  turn supported features">
      <failure message="Cannot read property &apos;write&apos; of undefined" type="TypeError"><![CDATA[TypeError: Canno                                  t read property 'write' of undefined
        at EspIdfDebugClient.doSend (c:\esp\github\vscode-esp-idf-extension\debug-adapter\node_modules\vscode-debugadap                                  ter-testsupport\lib\protocolClient.js:46:27)
        at c:\esp\github\vscode-esp-idf-extension\debug-adapter\node_modules\vscode-debugadapter-testsupport\lib\protoc                                  olClient.js:24:18
        at new Promise (<anonymous>)
        at EspIdfDebugClient.send (c:\esp\github\vscode-esp-idf-extension\debug-adapter\node_modules\vscode-debugadapte                                  r-testsupport\lib\protocolClient.js:23:16)
        at EspIdfDebugClient.initializeRequest (c:\esp\github\vscode-esp-idf-extension\debug-adapter\out\test\espIdfDeb                                  ugClient.js:90:21)
        at Object.<anonymous> (c:\esp\github\vscode-esp-idf-extension\debug-adapter\out\test\suite\adapter.test.js:48:3                                  1)
        at Generator.next (<anonymous>)
        at c:\esp\github\vscode-esp-idf-extension\debug-adapter\out\test\suite\adapter.test.js:24:71
        at new Promise (<anonymous>)
        at __awaiter (c:\esp\github\vscode-esp-idf-extension\debug-adapter\out\test\suite\adapter.test.js:20:12)                                                 at Context.<anonymous> (c:\esp\github\vscode-esp-idf-extension\debug-adapter\out\test\suite\adapter.test.js:41:                                  56)
        at processImmediate (internal/timers.js:439:21)]]></failure>
    </testcase>
  </testsuite>

fix debug adapter unit test

* read Cmakelists file for project name (VSC-248) (espressif#43) read build project_description json file for project name * Feature/localization kv val (VSC-226) (VSC-246) (espressif#41) * add gulp i18n validation and src missing key log * rm unused i18n field, add unknown field (espressif#48) * v0.1.4 * Added a custom Debug Adapter * fix old configs remove build before debug * removed outdated extension.test.ts * fix debug adapter unit test * removed repeated options * removed redundant requirements.txt * made `Upload testing.results.log` always executable * add adapter python reqs checking Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com> Co-authored-by: Andrey Gramakov <mail@agramakov.me>

* read Cmakelists file for project name (VSC-248) (espressif#43) read build project_description json file for project name * Feature/localization kv val (VSC-226) (VSC-246) (espressif#41) * add gulp i18n validation and src missing key log * rm unused i18n field, add unknown field (espressif#48) * v0.1.4 * Added a custom Debug Adapter * fix old configs remove build before debug * fix debug adapter unit test * DA python pkgs check (#3) * read Cmakelists file for project name (VSC-248) (espressif#43) read build project_description json file for project name * Feature/localization kv val (VSC-226) (VSC-246) (espressif#41) * add gulp i18n validation and src missing key log * rm unused i18n field, add unknown field (espressif#48) * v0.1.4 * Added a custom Debug Adapter * fix old configs remove build before debug * removed outdated extension.test.ts * fix debug adapter unit test * removed repeated options * removed redundant requirements.txt * made `Upload testing.results.log` always executable * add adapter python reqs checking Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com> Co-authored-by: Andrey Gramakov <mail@agramakov.me> * fix merge issues * log adapter output Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com> Co-authored-by: Andrey Gramakov <mail@agramakov.me>

an-dr · 2020-03-04T10:12:53Z

@brianignacio5 please help with conflicts

brianignacio5 · 2020-03-10T12:04:05Z

Please check an-dr#5

Fix Espressif master merge conflicts

an-dr · 2020-03-10T14:05:13Z

@brianignacio5 still exist :(

gerekon · 2020-03-24T10:56:19Z

esp_debug_adapter/debug_adapter/debug_backend/Pipfile

+pygdbmi = "==0.9.0.0"
+typing = ">=3.6.6"
+xmlrunner = "==1.7.7"
+unittest-xml-reporting = "*"


@an-dr I think we need to clean up debug_backend dependencies. From my point of view, we need to leave here pygdbmi only.

@brianignacio5 FYI

* read Cmakelists file for project name (VSC-248) (espressif#43) read build project_description json file for project name * Feature/localization kv val (VSC-226) (VSC-246) (espressif#41) * add gulp i18n validation and src missing key log * rm unused i18n field, add unknown field (espressif#48) * v0.1.4 Co-authored-by: Soumesh Banerjee <soumeshbanerjee@live.com>

igrr · 2020-03-26T06:33:52Z

Yay!

an-dr requested a review from brianignacio5 February 20, 2020 08:44

github-actions bot changed the title ~~Added a custom Debug Adapter~~ Added a custom Debug Adapter (VSC-250) Feb 20, 2020

igrr reviewed Feb 21, 2020

View reviewed changes

pwmb added the enhancement New feature or request label Feb 21, 2020

pwmb added this to the v0.2.0 milestone Feb 21, 2020

an-dr force-pushed the feature/debug-adapter branch 2 times, most recently from fa0b5f5 to 7544f14 Compare February 24, 2020 12:13

an-dr and others added 2 commits February 25, 2020 13:45

Added a custom Debug Adapter

e11a170

fix old configs remove build before debug

24aa493

Merge pull request #1 from brianignacio5/fix/use-new-configs

eaf7c9e

Fix/use new configs

an-dr force-pushed the feature/debug-adapter branch from 7544f14 to eaf7c9e Compare February 25, 2020 08:43

brianignacio5 and others added 2 commits February 26, 2020 15:31

fix debug adapter unit test

496a3bd

Merge pull request #2 from brianignacio5/fix/use-new-configs

f546451

fix debug adapter unit test

an-dr force-pushed the feature/debug-adapter branch from c70b51f to 077d8b0 Compare February 26, 2020 13:12

This was referenced Mar 3, 2020

Add DA pkg check #52

Closed

DA python pkgs check an-dr/vscode-esp-idf-extension#3

Merged

an-dr force-pushed the feature/debug-adapter branch from 9b36807 to 24b5566 Compare March 3, 2020 12:55

An dr/feature/debug adapter (#5)

8d8c1b9

Fix Espressif master merge conflicts

brianignacio5 force-pushed the master branch from e658db1 to 3e5a71c Compare March 24, 2020 09:53

brianignacio5 force-pushed the master branch from 3e5a71c to e658db1 Compare March 24, 2020 10:07

gerekon reviewed Mar 24, 2020

View reviewed changes

an-dr and others added 2 commits March 24, 2020 12:45

debug_backend package: removed everything but pygdbmi from the Pipfile

26954a7

pwmb mentioned this pull request Mar 25, 2020

Rebase of an-dr debug adapter (VSC-274) #70

Closed

pwmb and others added 3 commits March 25, 2020 23:10

Run prettier

49ccea8

yarn audit fix

bf500f2

Merge branch 'master' into feature/debug-adapter

ed65c95

brianignacio5 merged commit 7178fc8 into espressif:master Mar 26, 2020

pwmb modified the milestones: Release Candidate v0.2.0, Release Candidate v0.1.5 Mar 26, 2020

an-dr deleted the feature/debug-adapter branch May 18, 2020 07:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a custom Debug Adapter (VSC-250) #45

Added a custom Debug Adapter (VSC-250) #45

an-dr commented Feb 20, 2020

an-dr commented Feb 24, 2020

an-dr commented Feb 24, 2020

an-dr commented Feb 24, 2020

an-dr commented Feb 24, 2020

brianignacio5 commented Feb 25, 2020

an-dr commented Feb 25, 2020 •

edited

an-dr commented Mar 4, 2020

brianignacio5 commented Mar 10, 2020

an-dr commented Mar 10, 2020 •

edited

gerekon Mar 24, 2020 •

edited

gerekon Mar 24, 2020

igrr commented Mar 26, 2020

Added a custom Debug Adapter (VSC-250) #45

Added a custom Debug Adapter (VSC-250) #45

Conversation

an-dr commented Feb 20, 2020

an-dr commented Feb 24, 2020

an-dr commented Feb 24, 2020

an-dr commented Feb 24, 2020

an-dr commented Feb 24, 2020

brianignacio5 commented Feb 25, 2020

an-dr commented Feb 25, 2020 • edited

an-dr commented Mar 4, 2020

brianignacio5 commented Mar 10, 2020

an-dr commented Mar 10, 2020 • edited

gerekon Mar 24, 2020 • edited

Choose a reason for hiding this comment

gerekon Mar 24, 2020

Choose a reason for hiding this comment

igrr commented Mar 26, 2020

an-dr commented Feb 25, 2020 •

edited

an-dr commented Mar 10, 2020 •

edited

gerekon Mar 24, 2020 •

edited