Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: install matter python requirements (VSC-1030) #869

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Feature: install matter python requirements (VSC-1030) #869

merged 2 commits into from
Jan 18, 2023

Conversation

Diegorro98
Copy link
Contributor

@Diegorro98 Diegorro98 commented Jan 8, 2023

Description

Installs python requirements for ESP-Matter when it gets installed.
Also added a command to install this requirements in other python environments in case that is needed.

And fixed some notifications in ESP-Matter installation.

Fix #868 (VSC-1029)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Build the extension and run the whole installation process. Also I tested the command in another python env.

Test Configuration:

  • ESP-IDF Version: 4.4.3
  • OS (Windows,Linux and macOS): Linux

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@Diegorro98
Copy link
Contributor Author

Formatting rebase

@github-actions github-actions bot changed the title Feature/matter python requirements Feature/matter python requirements (VSC-1030) Jan 8, 2023
@Diegorro98 Diegorro98 changed the title Feature/matter python requirements (VSC-1030) Feature: install matter python requirements (VSC-1030) Jan 8, 2023
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor fix request

src/espMatter/espMatterDownload.ts Outdated Show resolved Hide resolved
@Diegorro98
Copy link
Contributor Author

@brianignacio5 Thanks for reviewing! Fixed the import in last rebase.

@brianignacio5 brianignacio5 merged commit 11494dc into espressif:master Jan 18, 2023
@Diegorro98 Diegorro98 deleted the feature/matter_python_requirements branch January 18, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install python requirements when installing ESP-MATTER (VSC-1029)
2 participants