Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim nvs csv columns #945

Merged
merged 3 commits into from Apr 28, 2023
Merged

trim nvs csv columns #945

merged 3 commits into from Apr 28, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Apr 19, 2023

Description

Trim columns in NVS partition table editor

Fixes #937

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Right click on a NVS partition table csv with CRLF line ending
  2. click ESP-IDF: Open NVS Partition Editor command
  3. Observe results. The table values should shown in the editor.
  • Expected behaviour: The table values should shown in the editor.

  • Expected output: The table values should shown in the editor.

How has this been tested?

Manual test using csv with CRLF end of lines characters.

Test Configuration:

  • ESP-IDF Version: 5.1
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Apr 19, 2023
@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Download the artifacts for this pull request:

@radurentea
Copy link
Collaborator

LGTM

@brianignacio5 brianignacio5 merged commit 1e24e02 into master Apr 28, 2023
5 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/nvs-partition-editor-eol branch April 28, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NVS Partition Editor doesn't read CSV files with CRLF endings under Windows (VSC-1088)
2 participants