Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom offset for flash binaries #957

Merged
merged 1 commit into from May 4, 2023
Merged

add custom offset for flash binaries #957

merged 1 commit into from May 4, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Apr 28, 2023 •
edited

Description

Add the option for custom offset for flashing a binary to a given hexadecimal offset.

Fixes #934

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Right click on a binary (.bin) and run the "Flash binary to partition..." command.
  2. Select custom offset and enter as hexadecimal value (example 0x8000).
  3. See the output in the ESP-IDF Output channel of the visual studio code.
  4. Observe results.

How has this been tested?

Manual testing

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Apr 28, 2023
@github-actions
Copy link

Download the artifacts for this pull request:

radurentea
radurentea approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit 46484f6 into master May 4, 2023
5 checks passed
@brianignacio5 brianignacio5 deleted the feature/custom-bin-flash-offset branch May 4, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radurentea radurentea radurentea approved these changes

Assignees

@brianignacio5 brianignacio5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Getting Offset for Flash (VSC-1085)
2 participants
@brianignacio5 @radurentea