Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] use pre-commit.ci #4770

Open
PythonFZ opened this issue Aug 9, 2023 · 0 comments
Open

[Suggestion] use pre-commit.ci #4770

PythonFZ opened this issue Aug 9, 2023 · 0 comments

Comments

@PythonFZ
Copy link
Contributor

PythonFZ commented Aug 9, 2023

I have setup https://pre-commit.ci/ with all of my actively maintained projects.
By doing so, I removed all code duplication of linting tools, which previously where present in the pyproject.toml (or in your case requirements.txt), the pre-commit-config.yaml and additionally in the CI to check linting for PRs.

This could probably remove all the linting from the requirements.txt
https://github.com/espressomd/espresso/blob/4aa06e7d26d35450b168a38573abdbc5ab4d2fb5/requirements.txt#L35C1-L41C18

pre-commit.ci will be an action that runs on the hooks on every commit. It will also commit changes to the PR, if the pre-commit hooks propose some (e.g. isort).
Furthermore, it will keep the linters up-to-date by creating PRs to update the linting tools automatically.

Auto-update example: zincware/IPSuite#180
Proposed changes example: zincware/IPSuite@9cfddc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant