increase size of timeForceComp array #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a system has more interactions than the size of timeForceComp, random segmentation faults will occur. Temporary hack: increase size of array. See issue espressopp#154
Current coverage is 39.0% (diff: 100%)@@ master #155 diff @@
==========================================
Files 421 421
Lines 22254 22254
Methods 5157 5018 -139
Messages 0 0
Branches 2370 2509 +139
==========================================
Hits 8682 8682
Misses 12986 12986
Partials 586 586
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the array timeForceComp is hard-coded in the VelocityVerlet class. If a system has more interactions than the size of timeForceComp, random segmentation faults will occur.
Temporary hack: increase size of array.
Long-term solution should be to re-write the whole timer setup in VelocityVerlet class.
See issue #154