Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logfile fixes part 1 #308

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Logfile fixes part 1 #308

merged 3 commits into from
Sep 4, 2019

Conversation

frenchie71
Copy link

Fixing the Watchdog Timeout due to sequential re-read of the file by using seek() and remembering the last position in the file. Takes roughly 80 ms per page.

Copy link
Collaborator

@omersiar omersiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I was thinking I invented the wheel by that time with this page by page algo. You did a great job here, all these stuff was alien to me, now I can tell seek function actually what I wanted. Nicely done.

@omersiar omersiar merged commit 98d49ca into esprfid:dev Sep 4, 2019
@frenchie71
Copy link
Author

Well, seeking in text files is not that obvious neither - I would have done it in some similar way like you to start - problem is it doesn't scale well. But again who could know esp-rfid would take off like it did? Usually seeking is done in fixed-length-block type files. But as the requests come in sequentially from the js file we can indeed save the last position.
On this note: I am planning a handful of more enhancements to logging, but I am not too keen on doing the website gulp stuff - I am thinking about adding log maintenance download, split, truncate roll over etc. - if I changed the html and js files would you mind doing the gulp conversion stuff?

@frenchie71
Copy link
Author

PS - for the record - this partially addresses issues #247 and #285

@omersiar
Copy link
Collaborator

omersiar commented Sep 4, 2019

I should check latest development on ESPAsyncWebServer library. There maybe additional fixes.

@frenchie71 frenchie71 deleted the log-fixes branch September 4, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants