-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed user pincode, added mqqt discovery for more data, other minor changes #644
base: dev
Are you sure you want to change the base?
Conversation
Thanks. Much appreciated. |
Hey @pvtex thank you :) Can you please try rebasing these commits on top of If you could also possibly reduce the number of commits it would help us better review the code. Otherwise just resolving the conflicts is fine :) Thanks! |
@pvtex if you struggle with Git we can have a call and figure out things together, I'm very interested in having a look at your code. Feel free to send me an email if you want to go this way, you find the address in my Github profile. Cheers |
I am right now rebasing my reposotory to the device branch. But could take some time |
d10e49b
to
55d6801
Compare
commit 55d6801 Author: wasn-eu <info@wasn.eu> Date: Wed Jun 5 16:42:09 2024 +0200 clean up
squashed all my commits and rebased my repo on dev branch |
Cool, thanks, can you please delete the .pio and ESP-Debug folders from your PR? |
deletet the folders .pio and ESP-Debug, |
Sorry, I'm not getting what are you trying to achieve with this PR. Can you please provide a description of the change? Also, it would be better to have one PR for one feature, to make it easier to review and discuss, so if there are multiple things here can we start from just one? |
mainly these things are changed/added:
|
No description provided.