Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.defineProperty(<function>, ...) #2501

Closed
bobrippling opened this issue May 18, 2024 · 1 comment · Fixed by #2504
Closed

Object.defineProperty(<function>, ...) #2501

bobrippling opened this issue May 18, 2024 · 1 comment · Fixed by #2504

Comments

@bobrippling
Copy link
Contributor

For debugging, I'd like to be able to do

Object.defineProperty(Bangle, ...)

At the moment I'm told it's because Bangle is not an object:

JsVar *jswrap_object_defineProperty(JsVar *parent, JsVar *propName, JsVar *desc) {
if (!jsvIsObject(parent)) {
jsExceptionHere(JSET_ERROR, "First argument must be Object, got %t", parent);
return 0;

If it seems reasonable, I'll make a PR to adjust the check to permit functions - I believe this is ok to be done on all functions:

Espruino/src/jsvar.c

Lines 206 to 209 in 01467c2

bool jsvHasChildren(const JsVar *v) {
if (!v) return false;
char f = v->flags&JSV_VARTYPEMASK;
return JSV_IS_FUNCTION(f) || JSV_IS_OBJECT(f) || JSV_IS_ARRAY(f) ||

@gfwilliams
Copy link
Member

Thanks! Yes, a PR for this would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants