Improve Project Structure #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n without inducing breaking changes
+ usethis::use_package("lifecycle")
+ update tests accordingly
+ add test for deprecation
+ devtools::document()
+ remove names of internal collaborators
This was
linked to
issues
Apr 18, 2024
|
Make the PR to another branch pls |
…msFile-to-modelParamsFile # Conflicts: # NEWS.md # R/project-configuration.R # inst/extdata/examples/TestProject/Configurations/Populations.xlsx # inst/extdata/examples/TestProject/ProjectConfiguration.xlsx # tests/testthat/test-utilities-population.R
… that depends on environment
+ use projectConfiguration$populationsCSV to locate population CSV files to read + add test to make sure all test scenarios can be properly created
…msFile-to-modelParamsFile # Conflicts: # NEWS.md
PavelBal
requested changes
May 6, 2024
There was a problem hiding this comment.
- Remove
compoundPropertiesFilefrom the project configuration excel (is not used anyways) - Add required steps to Write converter for project structure from v5 to v6 #627
PavelBal
requested changes
May 6, 2024
PavelBal
reviewed
May 6, 2024
+ replace leftover previous name
(wasn't doing what it was described to do.) + devtools::document()
PavelBal
approved these changes
May 6, 2024
+ general projectConfiguration improvements
PavelBal
approved these changes
May 13, 2024
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
projectConfiguration$paramsFilebyprojectConfiguration$modelParamsFile#558Parametersfolder intoConfigurations? #631Configurationexcel file names #633createDefaultProjectConfigurationtocreateProjectConfiguration#634