Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Floor Filter UI during loading #76

Closed
dfeinzimer opened this issue Jun 29, 2022 · 1 comment · Fixed by #122
Closed

Improve Floor Filter UI during loading #76

dfeinzimer opened this issue Jun 29, 2022 · 1 comment · Fixed by #122
Assignees
@dfeinzimer
Labels
enhancement New feature or request

Comments

@dfeinzimer
Copy link
Collaborator

dfeinzimer commented Jun 29, 2022 •
edited
Loading

  • Currently, when the Floor Filter is first opened and loading has not yet completed, the user is shown "No matches found". This can be improved upon by indicating to the user that loading is still in progress. As suggested by @zkline101 here.
@dfeinzimer dfeinzimer added the enhancement New feature or request label Jun 29, 2022
@dfeinzimer dfeinzimer self-assigned this Aug 15, 2022
@dfeinzimer
Copy link
Collaborator Author

dfeinzimer commented Aug 15, 2022 •
edited
Loading

The original feedback that prompted this ticket (the user sees "No matches found") is no longer valid as that UI isn't reachable until loading is complete.

An alternative would be to show a loading indicator in the button, in addition to disabling it.

@dfeinzimer dfeinzimer mentioned this issue Aug 15, 2022
Merged
@dfeinzimer dfeinzimer linked a pull request Aug 15, 2022 that will close this issue
Improve Floor Filter UI during loading #122
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfeinzimer dfeinzimer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Floor Filter UI during loading Esri/arcgis-maps-sdk-swift-toolkit
1 participant
@dfeinzimer