Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider the feasibility of Compass testing #88

Closed
dfeinzimer opened this issue Jul 13, 2022 · 2 comments
Closed

Consider the feasibility of Compass testing #88

dfeinzimer opened this issue Jul 13, 2022 · 2 comments
Labels
question Further information is requested

Comments

@dfeinzimer
Copy link
Collaborator

PR #70 rendered the existing compass tests unfeasible.

The existing tests were then removed in #87.

Should further changes be made to make the compass testable once again.
@dfeinzimer dfeinzimer added the question Further information is requested label Jul 13, 2022
@dfeinzimer dfeinzimer mentioned this issue Jul 13, 2022
Merged
@philium
Copy link
Contributor

philium commented Jul 13, 2022

I'm sorry for breaking the compass tests. I didn't realize they were there, but I would have if I had bothered to run the tests when making those compass changes. Some of the tests could be kept with only slight changes to Compass, such as making the shouldHide property internal instead of private.

@dfeinzimer
Copy link
Collaborator Author

Closing as duplicate of #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philium @dfeinzimer