Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop _TestOnly story suffix #9085

Open
1 of 5 tasks
jcfranco opened this issue Apr 8, 2024 · 0 comments
Open
1 of 5 tasks

Drop _TestOnly story suffix #9085

jcfranco opened this issue Apr 8, 2024 · 0 comments
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@jcfranco
Copy link
Member

jcfranco commented Apr 8, 2024 •
edited
Loading

Description

#9030 removed story filtering based on build output, so since all stories are test-related, we should drop the _TestOnly test suffix.

This should be done once #7180 is complete to avoid baseline screenshot syncing.

Note: renamed stories will show up as new screenshot tests and will need to be accepted as the new baseline.

Proposed Advantages

Simple and clear story naming.

Which Component

All _TestOnly named stories.

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 8, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Apr 8, 2024
@jcfranco jcfranco added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels Apr 8, 2024
@jcfranco jcfranco mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcfranco