Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump storybook to v8 #9030

Merged
merged 17 commits into from
Apr 6, 2024
Merged

build(deps): bump storybook to v8 #9030

merged 17 commits into from
Apr 6, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Apr 1, 2024 •
edited
Loading

Related Issue: N/A

Summary

Bump Storybook to v8.

Notes

  • Upgrades deps to the latest version
  • Removes unused/unsupported deps
  • Sets up interactions addon
  • Replaces the no-longer-supported @storybook/addon-knobs with fake ones to clean up and restore (@storybook/addon-controls) in a follow-up PR
  • Replaces RTL and theming addons with supported versions.
  • Removes "no test" and "test only" story filters as dynamic set ups are no longer required.
  • Drops unnecessary keydown intercepting since new shortcut to search stories is no longer / (now CMD/CTRL + K)
  • Sorts all icon options for snapshot consistency
  • Updates conventions doc
  • Removes no longer used component readme imports
  • Drops _NoTest stories except for all-variant stories for tile and tile-group
  • Keeps the _TestOnly story suffix until the Design token phase II - Integration across components #7180 lands.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Apr 1, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 1, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 2, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 3, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 3, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 3, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 3, 2024
@jcfranco
Copy link
Member Author

jcfranco commented Apr 3, 2024 •
edited
Loading

Screenshot test notes:

  • stories using the first icon are now consistent
  • text-area stories are displaying wider, not sure if this is expected or not
  • some shell and slide and flow stories are now rendering accurately this was not correct and was caused by misconfigured fake boolean knobs

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 5, 2024
@jcfranco jcfranco removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 5, 2024
@jcfranco jcfranco marked this pull request as ready for review April 5, 2024 20:11
@jcfranco jcfranco changed the title build(deps): bump storybook v8 build(deps): bump storybook to v8 Apr 5, 2024
@driskull
Copy link
Member

driskull commented Apr 5, 2024

screenshot-tests:preview is the replacement script for docs:preview correct?

driskull
driskull approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Tested it out and its much faster than previous versions.

@jcfranco
Copy link
Member Author

jcfranco commented Apr 5, 2024

screenshot-tests:preview is the replacement script for docs:preview correct?

You are correct, sir. Updated here.

@jcfranco jcfranco mentioned this pull request Apr 5, 2024
Closed
1 task
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 6, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 6, 2024
@jcfranco jcfranco merged commit e09ca31 into main Apr 6, 2024
16 checks passed
@jcfranco jcfranco deleted the jcfranco/bump-storybook branch April 6, 2024 08:33
@github-actions github-actions bot added this to the 2024-04-30 - Apr Release milestone Apr 6, 2024
This was referenced Apr 8, 2024
Closed
Open
Closed
Merged
jcfranco added a commit that referenced this pull request Apr 12, 2024
@jcfranco
refactor(storybook): drop unnecessary React logic (#9103)
23aad2d 
**Related Issue:** N/A

## Summary

This is no longer be needed after recent Storybook updates (see
#8944 and
#9030).

✨🧹✨
@jcfranco jcfranco mentioned this pull request Apr 19, 2024
Merged
jcfranco added a commit that referenced this pull request Apr 19, 2024
@jcfranco
build(deps): move @storybook/test to devDependencies (#9156)
6c40f6a 
**Related Issue:** N/A

## Summary

✨📦➡️🤓✨

This was unintentionally added as a dependency in #9030.
@jcfranco jcfranco mentioned this pull request Apr 24, 2024
Merged
jcfranco added a commit that referenced this pull request Apr 26, 2024
@jcfranco
chore: restore Stencil build step prior screenshot-tests:preview (#…
d529a10 
…9180)

**Related Issue:** N/A

## Summary

Restores build step unintentionally removed in
#9030.
@jcfranco jcfranco mentioned this pull request May 7, 2024
Closed
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@benelan benelan Awaiting requested review from benelan benelan is a code owner

@geospatialem geospatialem Awaiting requested review from geospatialem geospatialem is a code owner

Assignees

@jcfranco jcfranco

Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-04-30 - Apr Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcfranco @driskull