npm install missing /dist

[jrowlingson]

Not too familiar npm's package.json handling, so I might be missing something, but the following steps did not include /dist:

$ npm -v
2.7.5
$ npm cache clean
$ npm install --save-dev Esri/calcite-web
calcite-web@0.1.2 node_modules/calcite-web
$ ls -1 ./node_modules/calcite-web/
CHANGELOG.md
README.md
package.json

Specifying the version as a workaround.

[ungoldman]

This might be because of the gitignore. @paulcpederson want to try deleting it as part of branch build push tag release process?

[paulcpederson]

The release includes a dist. You must npm install from a specific version. Good 👀

#146 makes that more explicit in the README, I just hadn't updated the install docs since I built the new release process. Thanks! 👍

[ungoldman]

Yeah true, because of the way we're handling dist files they won't be in master, so you need to install the version explicitly like so:

npm install Esri/calcite-web@0.1.2

You know @paulcpederson now that npm supports private modules we could actually put this up on npm and not have to install privately through github.

[paulcpederson]

@ngoldman yeah I looked into that. That would force everybody that wants to use it to also have an npm private account. So nik, me, you, pat, cassidy, long, justin, etc... Hundreds of people all need a private account.

I think our hacky "GitHub access as module security" scheme will work for now. Hopefully when npm launches their organization support we can register calcite-web as an organization repo and that could be a way forward.

As long as we explicitly state that you must install @ a specific tag, I think it makes sense to force users to use a release. In your package.json when you install from a GitHub repo you don't get a version field. This way, people's projects must be locked down to a version and people won't have unintentional version updates in their project. If you just install Esri/calcite-web and we release breaking changes, when they npm install their project might break.

[ungoldman]

I see their evil strategy now. No org accounts.