Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Coordinate Conversion input coordinate -- formatting lost in Northern Hemisphere #527

Closed
BobBooth opened this issue Oct 31, 2018 · 16 comments

Comments

@BobBooth
Copy link
Contributor

BobBooth commented Oct 31, 2018

I added -- as a separator between the Lat Long values in a DD output. This output displayed in the List when I clicked in the Southern Hemisphere, but no dashes were returned when I clicked in the Northern Hemisphere.
image

The problem affects + and - symbols used as separators, as they also have significance in indicating hemisphere.
The problem does not affect other special characters, such as !,@,#,$,%,^,&,*,(,),=,<,>,?,/,,|,,.,

ArcGIS Pro 2.3.0 beta 1 build 14476
Coordinate Conversion 4.1.1.19 (latest October build)

@dfoll
Copy link
Collaborator

dfoll commented Apr 1, 2019

I would like to have this one worked on, but I think our team needs to research a little more first. Just thinking out loud without verifying the issue myself, I'm wondering if the example we give is confusing because - has a special meaning when it comes to coordinates.

  • Do we get the same behavior using $$ or is this unique to --?

Definitely need to fix this, just think we could clean up this issue a little bit first

@BobBooth
Copy link
Contributor Author

BobBooth commented Apr 1, 2019

@dfoll - good point. I will look at this again.

@dfoll dfoll added the CyberTech label Apr 8, 2019
@saip saip assigned saip and dfoll and unassigned saip Apr 9, 2019
@saip saip added the CT-Awaiting response Waiting for feedback from Esri team member label Apr 9, 2019
@dfoll
Copy link
Collaborator

dfoll commented Apr 9, 2019

CT-Awaiting Response because we should do the research to find out if this bug is occurring because "minus" is a meaningful character. See comment

@BobBooth
Copy link
Contributor Author

BobBooth commented Apr 9, 2019

@dfoll - it is because the minus sign is meaningful. I did check on that, added it to the original issue description.
"...
The problem affects + and - symbols used as separators, as they also have significance in indicating hemisphere.
The problem does not affect other special characters, such as !,@,#,$,%,^,&,*,(,),=,<,>,?,/,,|,,.,
..."

@dfoll
Copy link
Collaborator

dfoll commented Apr 17, 2019

@saip in the comment above, @BobBooth believes this problem is occuring because the minus sign is a special character. Knowing that, are we able to move ahead with fixing this issue?

@dfoll dfoll removed the CT-Awaiting response Waiting for feedback from Esri team member label Apr 17, 2019
@dfoll dfoll assigned CTLocalGovTeam and unassigned dfoll Apr 17, 2019
@dfoll
Copy link
Collaborator

dfoll commented Apr 17, 2019

spoke with @saip about this. I think we need to understand exactly how we need the parser to work to fix this issue. How do we get the code to understand - used as a delimiter, versus being used as a hemisphere designation?

For example, if the coordinate 54.72--48.37 is provided, how do we parse out if that is 54.72N-48.37W or 54.72N--48.37E from just what is provided textually.

@dfoll dfoll added the CT-Awaiting response Waiting for feedback from Esri team member label Apr 17, 2019
@dfoll dfoll assigned dfoll and CTLocalGovTeam and unassigned CTLocalGovTeam Apr 17, 2019
@BobBooth
Copy link
Contributor Author

So, we should detect+ and - symbols used as delimeters and warn the users that they are interpreted as hemisphere indicators only, cannot be also used as delimiters. Then not allow that input.
image

@dfoll
Copy link
Collaborator

dfoll commented Apr 18, 2019

@saip please check out @BobBooth comment on how we want the interaction to be.

  • if the user tries to enter a + or - when creating custom formatting for DD/DDM/DMS, the input box should highlight red, with a tooltip style message that tells the user "+ and - are significant characters for latitude/longitude and cannot be used in custom formatting"

@dfoll
Copy link
Collaborator

dfoll commented Apr 18, 2019

#600 was created to wrap up this workflow. Without #600 the user will be unable to "mark" something as being in the Southern or Western hemisphere

@dfoll dfoll removed their assignment Apr 18, 2019
@dfoll dfoll removed the CT-Awaiting response Waiting for feedback from Esri team member label Apr 18, 2019
saip added a commit that referenced this issue May 6, 2019
@dfoll
Copy link
Collaborator

dfoll commented Jun 18, 2019

The logic that was used to issue this was to disallow "+/-" characters when entering custom formatting. This broke the fix that was put in for #468 in the PR #518. To resolve this regression issue we need to improve the logic that was used.

  • Instead of absolutely disallowing "+/-", those characters should only be allowed within a latitude or longitude coordinate.
  • "+/-" are still allowed when embedded in a latitude or longitude coordinate.
    • Example: "DD-MM-SS.SS DD-MM-SS.SS" is a valid coordinate formatting "-" is within the coordinate
    • Example: "DD-MM-SS.SS**-DD-MM-SS.SS**" is not a valid coordinate pair "-" is in front of/not within the coordinate
    • Example: "-DD-MM-SS.SS DD-MM-SS.SS" is not a valid coordinate pair "-" is in front of/not within the coordinate
    • Example: "DD-MM-SS.SS**+DD-MM-SS.SS**" is not a valid coordinate pair "-" is in front of/not within the coordinate

@saip this comment is instead of a design doc I mentioned about how we want to proceed with #468/#527 let me know if you need any further clarification to proceed with implementing this fix

@saip
Copy link
Collaborator

saip commented Jun 19, 2019

@dfoll Please confirm if below mentioned are valid/invalid coordinate formatting

  • *-*DD-MM-SS.SS DD-MM-SS.SS
  • DD-MM-SS.SS*+*DD-MM-SS.SS **

@dfoll
Copy link
Collaborator

dfoll commented Jun 19, 2019

@saip

*-*DD-MM-SS.SS DD-MM-SS.SS is not a valid coordinate pair because there is a "-" in front of the latitude [assuming this is a lat/lon pair, but lon/lat would not change anything, i only used the word to refer to the position]

DD-MM-SS.SS*+*DD-MM-SS.SS ** is not a valid coordinate pair because there is a "+" in front of the longitude [assuming this is a lat/lon pair, but lon/lat would not change anything, i only used the word to refer to the position]

`

@dfoll
Copy link
Collaborator

dfoll commented Jun 24, 2019

When creating custom formatting "+/-" are treated a special characters and cannot be placed by the user in front of either latitude or longitude. This prevents confusion in a case where a "-" has been inserted in front of a "-" that indicates S or W hemisphere.

If a user wants a "-" to display to indicate S or W hemisphere, they will use the "Show - for S/W hemisphere" checkbox

@dfoll
Copy link
Collaborator

dfoll commented Jun 24, 2019

@lfunkhouser
Copy link
Member

Verified in MT 314 and CC 148 and solutionsdev - not on STG yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants